browser: fix possible races #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
oleiade,
codebien and
mstoykov
and removed request for
a team
mstoykov
approved these changes
Feb 10, 2025
joanlopez
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Same as #4522 this PR fixes usages of
sobek.Valueinside go routines which could lead to the race.It fixes this for following APIs:
Note that
SelectOptionandSetInputFilesstill not fully migrated, since some usages of thesobek.Valuerequires a bigger refactoring there.Why?
#4085
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)