Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy testing services from README and examples #4517

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Replace legacy testing services from README and examples #4517

merged 3 commits into from
Feb 6, 2025

Conversation

federicotdn
Copy link
Contributor

What?

Replace use of our legacy testing services with the new one at https://quickpizza.grafana.com/ .

Why?

Legacy test services are getting removed.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@federicotdn federicotdn requested a review from a team as a code owner February 6, 2025 14:25
@federicotdn federicotdn requested review from inancgumus and codebien and removed request for a team February 6, 2025 14:25
inancgumus
inancgumus reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions.

@inancgumus inancgumus merged commit 65ff6c9 into master Feb 6, 2025
28 checks passed
@inancgumus inancgumus deleted the replace-test-services branch February 6, 2025 19:30
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2025
Merged
@olegbespalov olegbespalov mentioned this pull request Feb 17, 2025
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@federicotdn @inancgumus @codebien