-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sourcemaps not uploading to Sentry #424
Conversation
SENTRY_ORG: ${{ vars.SENTRY_ORG }} | ||
SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main issue
@@ -21,8 +22,16 @@ export default defineConfig((env) => { | |||
assetFileNames: '[name].[ext]', | |||
}, | |||
}, | |||
sourcemap: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that sourcemaps were configured to be uploaded only for the main
process so I added the same config for preload
and renderer
as well.
Line 26 in c73eb40
sourcemap: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR fixes an issue where sourcemaps were not being uploaded to Sentry during a release.
When looking at the release logs we can see the following warning:
We can also see that the
SENTRY_PROJECT
andSENTRY_ORG
variables are not being read properly from the repo settings:This caused
@sentry/vite-plugin
not to know which Sentry project to associate the sourcemaps with.How to Test
Checklist
npm run lint
) and all checks pass.npm test
) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)