feat(SingleView): Remove page

e2e/fixtures/index.ts

@@ -6,11 +6,9 @@ import { AdHocViewPage } from './pages/AdHocViewPage';
 import { ComparisonDiffViewPage } from './pages/ComparisonDiffViewPage';
 import { ComparisonViewPage } from './pages/ComparisonViewPage';
 import { SettingsPage } from './pages/SettingsPage';
-import { SingleViewPage } from './pages/SingleViewPage';
 
 type Fixtures = {
   toolbar: Toolbar;
-  singleViewPage: SingleViewPage;
   comparisonViewPage: ComparisonViewPage;
   comparisonDiffViewPage: ComparisonDiffViewPage;
   adHocViewPage: AdHocViewPage;
@@ -43,12 +41,6 @@ export const test = base.extend<Options & Fixtures>({
   toolbar: async ({ page }, use) => {
     await use(new Toolbar(page));
   },
-  singleViewPage: async ({ page, failOnUncaughtExceptions }, use) => {
-    await withExceptionsAssertion(
-      { page, failOnUncaughtExceptions, use },
-      new SingleViewPage(page, DEFAULT_URL_PARAMS)
-    );
-  },
   comparisonViewPage: async ({ page, failOnUncaughtExceptions }, use) => {
     await withExceptionsAssertion(
       { page, failOnUncaughtExceptions, use },

e2e/fixtures/pages/ComparisonDiffViewPage.ts

@@ -52,4 +52,21 @@ export class ComparisonDiffViewPage extends PyroscopePage {
   getDiffPanel() {
     return this.page.getByTestId('diff-panel');
   }
+
+  getFlamegraph() {
+    return this.page.getByTestId('flameGraph');
+  }
+
+  getExportDataButton() {
+    return this.page.getByLabel('Export data');
+  }
+
+  // default position = node "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.(*Handler).ServeHTTP"
+  clickOnFlameGraphNode(position = { x: 180, y: 160 }) {
+    return this.getFlamegraph().click({ position });
+  }
+
+  getFunctionDetailsMenuItem() {
+    return this.getByRole('menuitem', { name: 'Function details' });
+  }
 }

e2e/tests/settings-view.spec.ts

@@ -28,44 +28,30 @@ test.describe('Plugin Settings', () => {
   });
 
   test.describe('Flame graph settings', () => {
-    test('Can be modified', async ({ settingsPage, singleViewPage }) => {
+    test('Can be modified', async ({ settingsPage, comparisonDiffViewPage }) => {
       await settingsPage.resetTestSettings();
 
       await settingsPage.getCollapsedFlamegraphsCheckbox().click();
       await settingsPage.getMaxNodesInput().fill('4');
       await settingsPage.getSaveSettingsButton().click();
       await expect(settingsPage.getSuccessAlertDialog()).toBeVisible();
 
-      await singleViewPage.goto();
-      await expect(singleViewPage.getFlamegraph()).toHaveScreenshot();
+      await comparisonDiffViewPage.goto();
+      await expect(comparisonDiffViewPage.getFlamegraph()).toHaveScreenshot();
     });
   });
 
   test.describe('Export settings', () => {
-    test('Can be modified', async ({ settingsPage, singleViewPage }) => {
+    test('Can be modified', async ({ settingsPage, comparisonDiffViewPage }) => {
       await settingsPage.resetTestSettings();
 
       await settingsPage.getEnableFlamegraphDotComCheckbox().click();
       await settingsPage.getSaveSettingsButton().click();
       await expect(settingsPage.getSuccessAlertDialog()).toBeVisible();
 
-      await singleViewPage.goto();
-      await singleViewPage.getExportDataButton().click();
-      await expect(singleViewPage.getByText('flamegraph.com')).not.toBeVisible();
-    });
-  });
-
-  test.describe('Enable Function Details', () => {
-    test('Can be modified', async ({ settingsPage, singleViewPage }) => {
-      await settingsPage.resetTestSettings();
-
-      await settingsPage.getEnableFunctionDetailsCheckbox().click();
-      await settingsPage.getSaveSettingsButton().click();
-      await expect(settingsPage.getSuccessAlertDialog()).toBeVisible();
-
-      await singleViewPage.goto();
-      await singleViewPage.clickOnFlameGraphNode();
-      expect(singleViewPage.getFunctionDetailsMenuItem()).not.toBeVisible();
+      await comparisonDiffViewPage.goto();
+      await comparisonDiffViewPage.getExportDataButton().click();
+      await expect(comparisonDiffViewPage.getByText('flamegraph.com')).not.toBeVisible();
     });
   });
 });