Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: factor out setDeveloperMode listener #180

Merged
merged 2 commits into from
Aug 28, 2019
Merged

refactor: factor out setDeveloperMode listener #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c766bf
refactor: factor out setDeveloperMode listener
fboechats Aug 27, 2019
1ffdbbf
Merge branch 'master' into refactor/set_developer_mode
fboechats Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions public/app/listeners/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const showExportSpacePrompt = require('./showExportSpacePrompt');
const showDeleteSpacePrompt = require('./showDeleteSpacePrompt');
const getUserFolder = require('./getUserFolder');
const getLanguage = require('./getLanguage');
const setDeveloperMode = require('./setDeveloperMode');


module.exports = {
loadSpace,
Expand All @@ -30,4 +32,5 @@ module.exports = {
showDeleteSpacePrompt,
getUserFolder,
getLanguage,
setDeveloperMode
};
15 changes: 15 additions & 0 deletions public/app/listeners/setDeveloperMode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
const { SET_DEVELOPER_MODE_CHANNEL } = require('../config/channels');
const { ERROR_GENERAL } = require('../config/errors');
const logger = require('../logger');

const setDeveloperMode = (mainWindow, db) => async (event, developerMode) => {
try {
db.set('user.developerMode', developerMode).write();
mainWindow.webContents.send(SET_DEVELOPER_MODE_CHANNEL, developerMode);
} catch (e) {
logger.error(e);
mainWindow.webContents.send(SET_DEVELOPER_MODE_CHANNEL, ERROR_GENERAL);
}
};

module.exports = setDeveloperMode;
11 changes: 2 additions & 9 deletions public/electron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ const {
setGeolocationEnabled,
getUserFolder,
getLanguage,
setDeveloperMode
} = require('./app/listeners');
const isMac = require('./app/utils/isMac');

Expand Down Expand Up @@ -351,15 +352,7 @@ app.on('ready', async () => {
});

// called when setting developer mode
ipcMain.on(SET_DEVELOPER_MODE_CHANNEL, (event, developerMode) => {
try {
db.set('user.developerMode', developerMode).write();
mainWindow.webContents.send(SET_DEVELOPER_MODE_CHANNEL, developerMode);
} catch (e) {
logger.error(e);
mainWindow.webContents.send(SET_DEVELOPER_MODE_CHANNEL, ERROR_GENERAL);
}
});
ipcMain.on(SET_DEVELOPER_MODE_CHANNEL, setDeveloperMode(mainWindow, db));

// called when getting geolocation enabled
ipcMain.on(
Expand Down