Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setting to allow reader to edit etherpad #946

Merged
merged 5 commits into from
Mar 3, 2025
Merged

feat: add setting to allow reader to edit etherpad #946

merged 5 commits into from
Mar 3, 2025

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Feb 27, 2025 •
edited
Loading

Add setting to etherpad to allow reader to write in the etherpad.

  • Create dedicated update form for etherpad
  • Add setting in both creation and update forms
  • Use generated endpoints for creation and update of etherpads

TODO

  • check on dev
  • write tests

close #632

@pyphilia pyphilia requested a review from spaenleh February 27, 2025 15:10
@pyphilia pyphilia self-assigned this Feb 27, 2025
spaenleh
spaenleh approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I have left some minor comments. Maybe we can tackle them in other PR after this one to improve the readability of the useEtherpad hook.

@pyphilia pyphilia marked this pull request as ready for review March 3, 2025 12:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pyphilia pyphilia merged commit b9a745c into main Mar 3, 2025
6 checks passed
@pyphilia pyphilia deleted the 632-etherpad-reader-permission branch March 3, 2025 13:06
@graasper graasper mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.22.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show option for etherpad to allow reader to edit
2 participants
@pyphilia @spaenleh