Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add BuildHost option to RPM packages #914

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

onshorechet
Copy link
Contributor

This commit adds the BuildHost option to the RPM specific configurations. If the build host is not provided it will default to os.Hostname() which is the previous behavior. This allows reproduce-able builds when the build environment spans multiple hosts.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2025
@caarlos0
Copy link
Member

Just missing the docs update.

Can do that after merge 🙏

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.42%. Comparing base (7a6c105) to head (46656b9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rpm/rpm.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   69.40%   69.42%   +0.01%     
==========================================
  Files          22       22              
  Lines        3131     3133       +2     
==========================================
+ Hits         2173     2175       +2     
  Misses        745      745              
  Partials      213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onshorechet
Copy link
Contributor Author

I'm happy to add that before merge. I can rebase it into one commit or leave it as a second, just not sure how you like your git history.

@caarlos0
Copy link
Member

@onshorechet ah, thanks

any way is fine, I usually squash and merge

This commit adds the BuildHost option to the RPM specific configurations. If the build
host is not provided it will default to os.Hostname() which is the previous behavior.
This allows reproduce-able builds when the build environment spans
multiple hosts.
@onshorechet
Copy link
Contributor Author

I'm guessing the doc's are generated from that configuration.md. I also updated the json schema. Thanks!

@caarlos0 caarlos0 merged commit 2c0c2a0 into goreleaser:main Mar 13, 2025
1 check passed
@caarlos0
Copy link
Member

thank you!

@github-actions github-actions bot added this to the 2.38.0 milestone Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants