-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add experimental S2A integration in client libraries grpc transport #3326
Merged
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
aebd139
bump grpc versions.
rmehta19 b456935
bump auth to local SNAPSHOT.
rmehta19 3510643
implementation.
rmehta19 e799526
tests.
rmehta19 70ae8d0
use endpoint override.
rmehta19 7ef7313
fix typo
rmehta19 6d98115
cleanup.
rmehta19 250fecc
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 8469a1a
resolve merge conflict with PR#1560
rmehta19 e880fbe
remove unnecessary dependency.
rmehta19 28adb31
add mtlsEndpoint to ClientSettings.
rmehta19 b3e2e06
add logs.
rmehta19 90892ef
remove ignore rule.
rmehta19 33b710c
separate into single condition if statements.
rmehta19 b320cc2
add logic to resolve endpointOverride / customEndpoint in EndpointCon…
rmehta19 035e17e
add javadocs.
rmehta19 759c3df
mtlsendpoint changes.
rmehta19 c096cb7
isS2AEnabled.
rmehta19 dc4b61e
expose endpointContext.
rmehta19 d4fcc71
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 393190a
remove needsEndpointContext.
rmehta19 30a37c2
reduce nesting.
rmehta19 c3b93a0
check Strings null or empty.
rmehta19 18a4cf2
remove unecessary check.
rmehta19 0897730
set endpointContext in grpc transport provider tests.
rmehta19 9901656
package private.
rmehta19 257c515
set System::getenv as envProvider.
rmehta19 e4565f4
add javadoc.
rmehta19 33bd7a6
no getters for endpointcontext.
rmehta19 f9eef5b
nits + package private.
rmehta19 a7af12e
update javadocs + add mtlsServiceAddress.
rmehta19 eb70225
add javadocs.
rmehta19 2a50985
update readme.
rmehta19 943683d
private + readme updates.
rmehta19 34f030f
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 fb3d608
update CLIRR-ignored-differences.
rmehta19 926faca
mark endpoint as Obsolete.
rmehta19 4ee2ee9
fix remaining tests to mock endpointContext.resolvedEndpoint().
rmehta19 2f70bf8
modify obsolete statement.
rmehta19 cb5768f
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 c96c760
revert usage of endpointContext.resolvedEndpoint().
rmehta19 30ff3d6
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 791ab2c
don't propogate endpointContext.
rmehta19 a4ee6c5
log as warning.
rmehta19 6eeccb2
package private + comment on S2A env var.
rmehta19 03eb991
package private useS2A.
rmehta19 91175ef
check if files exist.
rmehta19 04d47a0
default unsupported exception.
rmehta19 7d7b233
log a warning.
rmehta19 a42dcbd
pass File to TlsChannelCredentials.
rmehta19 56551c6
test createPlaintextS2AChannelCredentials.
rmehta19 1ff7a92
fix file checking logic.
rmehta19 2958fb4
document mtls mds.
rmehta19 c9a7edd
rename mtls mds vars to be clear these are filepaths.
rmehta19 8bf770d
bump auth dep and add some tests for createS2ASecuredChannelCredentials.
rmehta19 33faba1
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 924a4e4
fix BUILD.
rmehta19 b00fd53
Merge branch 'main' into grpc-channel-using-s2a
rmehta19 ca5be85
fix: Do not build s2a frpm grpc's Bazel target.
blakeli0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
check if files exist.
- Loading branch information
commit 91175ef017d1acf1ddd00cf3af2ad64037583fdd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
if (rootFile.isFile() && certKeyFile.isFile())
? Or refactor this toto reduce indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is my bad! Changed to
if (rootFile.isFile() && certKeyFile.isFile())
. Thanks for catching! 1ff7a92There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think that means we don't have any test coverage for
createS2ASecuredChannelCredentials()
though, and to some extend, also no test coverage for the logics increateSingleChannel()
.It's probably hard to test the channels created from
createSingleChannel()
since there are no getters inManagedChannel
for us to verify it, and that's probably we don't have much test for it in the past either. For the new methodcreateS2ASecuredChannelCredentials()
, we could probably extract the file path as parameters of this method so that we can unit test it properly.