Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix: Add async context manager return types #496

Merged
merged 2 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,7 @@ async def sample_delete_glossary():
# Done; return the response.
return response

async def __aenter__(self):
async def __aenter__(self) -> "TranslationServiceAsyncClient":
return self

async def __aexit__(self, exc_type, exc, tb):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,7 @@ async def sample_delete_glossary():
# Done; return the response.
return response

async def __aenter__(self):
async def __aenter__(self) -> "TranslationServiceAsyncClient":
return self

async def __aexit__(self, exc_type, exc, tb):
Expand Down
12 changes: 4 additions & 8 deletions tests/unit/gapic/translate_v3/test_translation_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -2841,9 +2841,11 @@ async def test_list_glossaries_async_pages():
RuntimeError,
)
pages = []
async for page_ in (
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
async for page_ in ( # pragma: no branch
await client.list_glossaries(request={})
).pages: # pragma: no branch
).pages:
pages.append(page_)
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
assert page_.raw_page.next_page_token == token
Expand Down Expand Up @@ -2873,9 +2875,6 @@ def test_get_glossary(request_type, transport: str = "grpc"):
name="name_value",
entry_count=1210,
display_name="display_name_value",
language_pair=translation_service.Glossary.LanguageCodePair(
source_language_code="source_language_code_value"
),
)
response = client.get_glossary(request)

Expand Down Expand Up @@ -5610,9 +5609,6 @@ def test_get_glossary_rest(request_type):
name="name_value",
entry_count=1210,
display_name="display_name_value",
language_pair=translation_service.Glossary.LanguageCodePair(
source_language_code="source_language_code_value"
),
)

# Wrap the value into a proper Response obj
Expand Down
12 changes: 4 additions & 8 deletions tests/unit/gapic/translate_v3beta1/test_translation_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -2713,9 +2713,11 @@ async def test_list_glossaries_async_pages():
RuntimeError,
)
pages = []
async for page_ in (
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
async for page_ in ( # pragma: no branch
await client.list_glossaries(request={})
).pages: # pragma: no branch
).pages:
pages.append(page_)
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
assert page_.raw_page.next_page_token == token
Expand Down Expand Up @@ -2744,9 +2746,6 @@ def test_get_glossary(request_type, transport: str = "grpc"):
call.return_value = translation_service.Glossary(
name="name_value",
entry_count=1210,
language_pair=translation_service.Glossary.LanguageCodePair(
source_language_code="source_language_code_value"
),
)
response = client.get_glossary(request)

Expand Down Expand Up @@ -5412,9 +5411,6 @@ def test_get_glossary_rest(request_type):
return_value = translation_service.Glossary(
name="name_value",
entry_count=1210,
language_pair=translation_service.Glossary.LanguageCodePair(
source_language_code="source_language_code_value"
),
)

# Wrap the value into a proper Response obj
Expand Down