Skip to content

Commit

Permalink
feat: postgres dialect - review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ansh0l committed Jun 12, 2022
1 parent 69713de commit e112a1d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions google/cloud/spanner_v1/database.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ class Database(object):
If a dict is provided, it must be of the same form as either of the protobuf
messages :class:`~google.cloud.spanner_admin_database_v1.types.EncryptionConfig`
or :class:`~google.cloud.spanner_admin_database_v1.types.RestoreDatabaseEncryptionConfig`
:type database_dialect:
:class:`~google.cloud.spanner_admin_database_v1.types.DatabaseDialect`
:param database_dialect:
(Optional) database dialect for the database
"""

_spanner_api = None
Expand Down
2 changes: 1 addition & 1 deletion tests/system/test_session_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1983,7 +1983,7 @@ def test_execute_sql_w_numeric_bindings(not_emulator, not_postgres, sessions_dat
)


def test_execute_sql_w_json_bindings(not_emulator, sessions_database):
def test_execute_sql_w_json_bindings(not_emulator, sessions_database, database_dialect):
_bind_test_helper(
sessions_database,
database_dialect,
Expand Down

0 comments on commit e112a1d

Please sign in to comment.