-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support transactions management #535
Merged
Merged
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fb958f9
feat: implement transactions management
4b7273f
feat: transactions management implementation
44fd7dd
add autocommit property setter and getter, add more system tests
3861550
Merge branch 'master' into transactions_retry
dc7e5a4
fix unit tests
75e0685
use global sessions pool, use single transaction for single connectio…
0f69035
del excess license lines
2c24eac
Merge branch 'master' into transactions_retry
mf2199 79666d7
don't run DDL in transactions, fix system tests on emulator
635ec33
Merge branch 'transactions_retry' of https://github.com/q-logic/pytho…
84d67fe
fix emulator config
61e2af8
don't roll back transactions which are already rolled back on connect…
efbdab3
some fixes
5e23e59
don't use global pool
95a36b4
Merge branch 'master' into transactions_retry
c24t ba1df36
add autocommit mode note
f691dc9
Merge branch 'transactions_retry' of https://github.com/q-logic/pytho…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a connection pool for each
Connection
is too much. One connection will never use more than one session at any time, as:This is fine for a prototype, for production purposes, the implementation should do one of the following:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm-m, as our common way to create connections is a constructor-function (according to PEP 249), which doesn't save any condition, it seems like we should initiate session pool for the whole package. I don't see big problems with that.