Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Client.delete_job_metadata method to remove job metadata #610

Merged
merged 6 commits into from
Apr 26, 2021
Merged

feat: add Client.delete_job_metadata method to remove job metadata #610

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f1ce48
feat: add `Client.delete_job` method to remove job metadata
tswast Apr 14, 2021
a1b9375
Update google/cloud/bigquery/client.py
tswast Apr 23, 2021
1e29763
Update tests/system/test_client.py
tswast Apr 23, 2021
3efed28
Merge branch 'master' of github.com:googleapis/python-bigquery into d…
tswast Apr 23, 2021
cee67f5
Merge branch 'delete_job' of github.com:tswast/python-bigquery into d…
tswast Apr 23, 2021
4ecc09f
rename to delete_job_metadata
tswast Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,7 @@ def delete_job(
# Location is always required for jobs.delete()
extra_params["location"] = location

path = "/projects/{}/jobs/{}/delete".format(project, job_id)
path = f"/projects/{project}/jobs/{job_id}/delete"

span_attributes = {"path": path, "job_id": job_id, "location": location}

Expand Down
2 changes: 1 addition & 1 deletion tests/system/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def _has_rows(result):


def _make_dataset_id(prefix):
return "python_bigquery_tests_system_%s%s" % (prefix, unique_resource_id())
return "python_bigquery_tests_system_{prefix}{unique_resource_id()}"


def _load_json_schema(filename="schema.json"):
Expand Down