Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set chunk size for async stream content #702

Merged
merged 2 commits into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion google/api_core/rest_streaming_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ def __init__(
):
self._response = response
self._chunk_size = 1024
self._response_itr = self._response.content().__aiter__()
# TODO(https://github.com/googleapis/python-api-core/issues/703): mypy does not recognize the abstract content
# method as an async generator as it looks for the `yield` keyword in the implementation.
# Given that the abstract method is not implemented, mypy fails to recognize it as an async generator.
# mypy warnings are silenced until the linked issue is resolved.
self._response_itr = self._response.content(self._chunk_size).__aiter__() # type: ignore
super(AsyncResponseIterator, self).__init__(
response_message_cls=response_message_cls
)
Expand Down