Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: remove eslint, update gax, fix generated protos, run the generator #24

Merged
merged 2 commits into from
Apr 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .jsdoc.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = {
includePattern: '\\.js$'
},
templates: {
copyright: 'Copyright 2019 Google, LLC.',
copyright: 'Copyright 2020 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: '@google-cloud/media-translation',
Expand Down
2 changes: 1 addition & 1 deletion .prettierrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
14 changes: 5 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,20 @@
"prepare": "npm run compile-protos && npm run compile",
"system-test": "c8 mocha build/system-test",
"test": "c8 mocha build/test",
"fix": "gts fix && eslint samples --fix",
"lint": "gts check && eslint samples",
"prelint": "cd samples; npm link ../; npm i",
"fix": "gts fix",
"lint": "gts fix",
"prelint": "cd samples; npm link ../; npm install",
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../"
},
"dependencies": {
"google-gax": "^2.0.1"
"google-gax": "^2.1.0"
},
"devDependencies": {
"@types/mocha": "^7.0.0",
"@types/node": "^12.12.29",
"@types/sinon": "^9.0.0",
"c8": "^7.1.0",
"eslint": "^6.8.0",
"eslint-config-prettier": "^6.10.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.1.2",
"gts": "2.0.0",
"gts": "^2.0.0",
"jsdoc": "^3.6.3",
"jsdoc-fresh": "^1.0.2",
"jsdoc-region-tag": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion protos/protos.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util;

// Exported root namespace
var $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {});
var $root = $protobuf.roots._google_cloud_media_translation_2_0_0_protos || ($protobuf.roots._google_cloud_media_translation_2_0_0_protos = {});

$root.google = (function() {

Expand Down
1 change: 1 addition & 0 deletions protos/protos.json
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@
},
"rpc": {
"options": {
"cc_enable_arenas": true,
"go_package": "google.golang.org/genproto/googleapis/rpc/status;status",
"java_multiple_files": true,
"java_outer_classname": "StatusProto",
Expand Down
19 changes: 18 additions & 1 deletion synth.metadata
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
{
"updateTime": "2020-04-01T23:52:56.801063Z",
"updateTime": "2020-04-11T01:36:16.535216Z",
"sources": [
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "1bd77e8ce6f953ac641af7966d0c52646afc16a8",
"internalRef": "305974465"
}
},
{
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5"
}
}
],
"destinations": [
{
"client": {
Expand Down
4 changes: 2 additions & 2 deletions synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@

# Node.js specific cleanup
subprocess.run(['npm', 'install'])
subprocess.run(['npm', 'run', 'fix'])

subprocess.run(['npm', 'run', 'lint'])
subprocess.run(['npx', 'compileProtos', 'src'])
2 changes: 1 addition & 1 deletion test/gapic_speech_translation_service_v1beta1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ describe('v1beta1.SpeechTranslationServiceClient', () => {
stream.write(request);
stream.end();
});
assert.rejects(async () => {
await assert.rejects(async () => {
await promise;
}, expectedError);
assert(
Expand Down