Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint #384

Merged
merged 1 commit into from
Apr 29, 2019
Merged

fix: lint #384

merged 1 commit into from
Apr 29, 2019

Conversation

stephenplusplus
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2019
callmehiphop
callmehiphop approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes!

@callmehiphop callmehiphop added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2019
@codecov
Copy link

codecov bot commented Apr 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e7a6a29). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #384   +/-   ##
=========================================
  Coverage          ?   93.18%           
=========================================
  Files             ?        2           
  Lines             ?       88           
  Branches          ?        0           
=========================================
  Hits              ?       82           
  Misses            ?        6           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a6a29...b0a5135. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 9a4d746 into googleapis:master Apr 29, 2019
@stephenplusplus stephenplusplus deleted the spp--lint branch April 29, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenplusplus @callmehiphop @googlebot