Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

fix(compute): revert proto3_optional, required removal on parent_id (#714) #717

Merged
merged 2 commits into from
Apr 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion protos/google/cloud/compute/v1/compute.proto
Original file line number Diff line number Diff line change
Expand Up @@ -16439,7 +16439,10 @@ message MoveFirewallPolicyRequest {
string firewall_policy = 498173265 [(google.api.field_behavior) = REQUIRED];

// The new parent of the firewall policy.
optional string parent_id = 459714768 [(google.cloud.operation_request_field) = "parent_id"];
string parent_id = 459714768 [
(google.api.field_behavior) = REQUIRED,
(google.cloud.operation_request_field) = "parent_id"
];

// An optional request ID to identify requests. Specify a unique request ID so that if you must retry your request, the server will know to ignore the request if it has already been completed. For example, consider a situation where you make an initial request and the request times out. If you make the request again with the same request ID, the server can check if original operation with the same request ID was received, and if so, will ignore the second request. This prevents clients from accidentally creating duplicate commitments. The request ID must be a valid UUID with the exception that zero UUID is not supported ( 00000000-0000-0000-0000-000000000000).
optional string request_id = 37109963;
Expand Down
5 changes: 1 addition & 4 deletions protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 7 additions & 21 deletions protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion samples/generated/v1/firewall_policies.move.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

'use strict';

function main(firewallPolicy) {
function main(firewallPolicy, parentId) {
// [START compute_v1_generated_FirewallPolicies_Move_async]
/**
* TODO(developer): Uncomment these variables before running the sample.
Expand Down Expand Up @@ -48,6 +48,7 @@ function main(firewallPolicy) {
// Construct request
const request = {
firewallPolicy,
parentId,
};

// Run request
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3662,7 +3662,7 @@
"segments": [
{
"start": 25,
"end": 58,
"end": 59,
"type": "FULL"
}
],
Expand Down