Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabling endToEndTracing support in Connection API #3412

Merged
merged 7 commits into from
Oct 22, 2024
Merged

feat: Enabling endToEndTracing support in Connection API #3412

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7f72d6
feat: Enabling endToEndTracing support in Connection API
ankiaga Oct 15, 2024
846a002
fix formatting
ankiaga Oct 15, 2024
39d392b
Comments incorporated
ankiaga Oct 21, 2024
751c947
formatting fixed
ankiaga Oct 21, 2024
e4f86e8
formatting fixed
ankiaga Oct 21, 2024
5de71f8
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/co…
ankiaga Oct 22, 2024
bf3361c
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/co…
ankiaga Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/co… 
…nnection/ConnectionProperties.java

Co-authored-by: Knut Olav Løite <[email protected]>
  • Loading branch information
@ankiaga @olavloite
ankiaga and olavloite authored Oct 22, 2024
commit bf3361c15e7e6e6e0d250327200b46f448e13b24
4 changes: 2 additions & 2 deletions ...cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ class ConnectionProperties {
ENABLE_END_TO_END_TRACING_PROPERTY_NAME,
"Enable end-to-end tracing (true/false) to generate traces for both the time "
+ "that is spent in the client, as well as time that is spent in the Spanner server. "
+ "Server side traces would always go to Google Cloud Trace so to see end to end traces, "
+ "client should choose an exporter that exports the traces to Google Cloud Trace.",
+ "Server side traces can only go to Google Cloud Trace, so to see end to end traces, "
+ "the application should configure an exporter that exports the traces to Google Cloud Trace.",
DEFAULT_ENABLE_END_TO_END_TRACING,
BooleanConverter.INSTANCE,
Context.STARTUP);
Expand Down
Loading