Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision: Flatten case of logo text in systest. #9159

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Vision: Flatten case of logo text in systest. #9159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vision/tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_detect_logos_content(self):

# Check to ensure we got what we expect.
assert len(response.logo_annotations) == 1
assert response.logo_annotations[0].description == "google"
assert response.logo_annotations[0].description.lower() == "google"

def test_detect_logos_file_handler(self):
# Get a file handler, and make the request using it.
Expand All @@ -90,15 +90,15 @@ def test_detect_logos_file_handler(self):

# Check to ensure we got what we expect.
assert len(response.logo_annotations) == 1
assert response.logo_annotations[0].description == "google"
assert response.logo_annotations[0].description.lower() == "google"

def test_detect_logos_filename(self):
# Make the request with the filename directly.
response = self.client.logo_detection({"source": {"filename": LOGO_FILE}})

# Check to ensure we got what we expect.
assert len(response.logo_annotations) == 1
assert response.logo_annotations[0].description == "google"
assert response.logo_annotations[0].description.lower() == "google"

def test_detect_logos_gcs(self):
# Upload the image to Google Cloud Storage.
Expand All @@ -121,7 +121,7 @@ def test_detect_logos_gcs(self):

# Check the response.
assert len(response.logo_annotations) == 1
assert response.logo_annotations[0].description == "google"
assert response.logo_annotations[0].description.lower() == "google"

def test_detect_logos_async(self):
# Upload the image to Google Cloud Storage.
Expand Down Expand Up @@ -177,7 +177,7 @@ def test_detect_logos_async(self):
assert len(responses) == 1
logo_annotations = responses[0]["logoAnnotations"]
assert len(logo_annotations) == 1
assert logo_annotations[0]["description"] == "google"
assert logo_annotations[0]["description"].lower() == "google"


class TestVisionClientFiles(VisionSystemTestBase):
Expand Down