Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for BigQuery Models. #2039

Merged
merged 5 commits into from
Jul 22, 2019
Merged

feat: Add support for BigQuery Models. #2039

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a64d07e
feat: adds support for BigQuery ML Models
danielgsims Jun 28, 2019
5fac570
fix: modifies order of params to prevent accidental overwrites
danielgsims Jul 1, 2019
df35642
Address review feedback
jdpedrie Jul 16, 2019
c92dcf5
Address review comments
jdpedrie Jul 19, 2019
9167426
add param description
jdpedrie Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions BigQuery/src/Dataset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,11 @@ public function model($id, array $info = [])
/**
* Fetches all of the models in the dataset.
*
* Please note that Model instances created by list calls may not contain a
* full representation of the model resource. To obtain a full resource on a
* Model instance, call {@see Google\Cloud\BigQuery\Model::reload()}.
* Please note that Model instances obtained from this method contain only a
* subset of the resource representation. Fields returned include
* `modelReference`, `modelType`, `creationTime`, `lastModifiedTime` and
* `labels`. To obtain a full representation, call
* {@see Google\Cloud\BigQuery\Model::reload()}.
*
* Example:
* ```
Expand Down
9 changes: 5 additions & 4 deletions BigQuery/src/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,17 @@ class Model

/**
* @param ConnectionInterface $connection Represents a connection to BigQuery.
* @param $id string The model's ID.
* @param $datasetId string The dataset's ID.
* @param $projectId string The project's ID.
* @param string $id The model's ID.
* @param string $datasetId The dataset's ID.
* @param string $projectId The project's ID.
* @param array $info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor nit, could we please add a description?

*/
public function __construct(
ConnectionInterface $connection,
$id,
$datasetId,
$projectId,
$info = []
array $info = []
) {
$this->connection = $connection;
$this->identity = [
Expand Down