Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors-reporting: Unhandled rejections are reported #2360

Merged
merged 7 commits into from
Jun 15, 2017
Merged

errors-reporting: Unhandled rejections are reported #2360

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
254328e
errors-report:Document unhandledRejection handling
DominicKramer Jun 5, 2017
666b57e
error-reporting: Unhandled rejections are reported
DominicKramer Jun 8, 2017
a05f25b
Report unhandledRejections is disabled by default
DominicKramer Jun 12, 2017
34d6f37
Address GitHub comments
DominicKramer Jun 14, 2017
a57d5ed
Specify rejections not reported by default in docs
DominicKramer Jun 14, 2017
6c0a399
Update README config sect to match default values
DominicKramer Jun 15, 2017
cb7362c
Update test name to match behavior
DominicKramer Jun 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README config sect to match default values 
In particular, the configuration section, as well as the section
discussing the handling of unhandled rejections, discussed the
default behavior of handling unhandled rejections.  Now the
default action is not described in the configuration section so
that only one section describes that behavior.
  • Loading branch information
@DominicKramer
DominicKramer committed Jun 15, 2017
commit 6c0a399e134f754daa17c5957244a597e24dea13
4 changes: 2 additions & 2 deletions packages/error-reporting/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ var errors = require('@google-cloud/error-reporting')({
// defaults to 2 (warnings)
logLevel: 2,
// determines whether or not unhandled rejections are reported to the
// error-reporting console. The default value of this property is true.
reportUnhandledRejections: false,
// error-reporting console
reportUnhandledRejections: true,
serviceContext: {
service: 'my-service',
version: 'my-service-version'
Expand Down