Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [run] Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service #9908

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: [run] Removes accidentally exposed field service.traffic_tags_cleanup_threshold in Cloud Run Service #9908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4694f
fix: Removes accidentally exposed field service.traffic_tags_cleanup_…
gcf-owl-bot[bot] Sep 28, 2023
030a0d7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java-run/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,20 @@ If you are using Maven without the BOM, add this to your dependencies:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-run</artifactId>
<version>0.25.0</version>
<version>0.24.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-run:0.25.0'
implementation 'com.google.cloud:google-cloud-run:0.24.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-run" % "0.25.0"
libraryDependencies += "com.google.cloud" % "google-cloud-run" % "0.24.0"
```
<!-- {x-version-update-end} -->

Expand Down
9 changes: 0 additions & 9 deletions ...un/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientHttpJsonTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ public void createServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -210,7 +209,6 @@ public void createServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -295,7 +293,6 @@ public void getServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -371,7 +368,6 @@ public void getServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -547,7 +543,6 @@ public void updateServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -591,7 +586,6 @@ public void updateServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -654,7 +648,6 @@ public void updateServiceExceptionTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -698,7 +691,6 @@ public void deleteServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -779,7 +771,6 @@ public void deleteServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down
7 changes: 0 additions & 7 deletions java-run/google-cloud-run/src/test/java/com/google/cloud/run/v2/ServicesClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public void createServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -217,7 +216,6 @@ public void createServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -301,7 +299,6 @@ public void getServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -371,7 +368,6 @@ public void getServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -529,7 +525,6 @@ public void updateServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -607,7 +602,6 @@ public void deleteServiceTest() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down Expand Up @@ -685,7 +679,6 @@ public void deleteServiceTest2() throws Exception {
.setUri("uri116076")
.addAllCustomAudiences(new ArrayList<String>())
.setSatisfiesPzs(true)
.setTrafficTagsCleanupThreshold(-795495828)
.setReconciling(true)
.setEtag("etag3123477")
.build();
Expand Down
28 changes: 14 additions & 14 deletions java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ public ValuesCase getValuesCase() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -142,8 +142,8 @@ public java.lang.String getName() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down Expand Up @@ -743,8 +743,8 @@ public Builder clearValues() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -766,8 +766,8 @@ public java.lang.String getName() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -789,8 +789,8 @@ public com.google.protobuf.ByteString getNameBytes() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -811,8 +811,8 @@ public Builder setName(java.lang.String value) {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -829,8 +829,8 @@ public Builder clearName() {
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down
8 changes: 4 additions & 4 deletions ...-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/EnvVarOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public interface EnvVarOrBuilder
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -40,8 +40,8 @@ public interface EnvVarOrBuilder
*
*
* <pre>
* Required. Name of the environment variable. Must be a C_IDENTIFIER, and
* must not exceed 32768 characters.
* Required. Name of the environment variable. Must not exceed 32768
* characters.
* </pre>
*
* <code>string name = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down
8 changes: 4 additions & 4 deletions java-run/proto-google-cloud-run-v2/src/main/java/com/google/cloud/run/v2/RunJobRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ com.google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride getContainerOv
*
*
* <pre>
* RunJob Overrides that contains Execution fields to be overridden on the go.
* RunJob Overrides that contains Execution fields to be overridden.
* </pre>
*
* Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides}
Expand Down Expand Up @@ -391,7 +391,7 @@ public interface ContainerOverrideOrBuilder
*
*
* <pre>
* Per container override specification.
* Per-container override specification.
* </pre>
*
* Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride}
Expand Down Expand Up @@ -849,7 +849,7 @@ protected Builder newBuilderForType(
*
*
* <pre>
* Per container override specification.
* Per-container override specification.
* </pre>
*
* Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides.ContainerOverride}
Expand Down Expand Up @@ -2254,7 +2254,7 @@ protected Builder newBuilderForType(
*
*
* <pre>
* RunJob Overrides that contains Execution fields to be overridden on the go.
* RunJob Overrides that contains Execution fields to be overridden.
* </pre>
*
* Protobuf type {@code google.cloud.run.v2.RunJobRequest.Overrides}
Expand Down
Loading