Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [tpu] restrict the visibility of an API #9406

Merged
merged 2 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-tpu/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.13.0</version>
<version>26.14.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -195,7 +195,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-tpu.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-tpu/2.16.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-tpu/2.17.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1636,154 +1636,6 @@ public final OperationFuture<QueuedResource, OperationMetadata> deleteQueuedReso
return stub.deleteQueuedResourceCallable();
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Resets a QueuedResource TPU instance
*
* <p>Sample code:
*
* <pre>{@code
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (TpuClient tpuClient = TpuClient.create()) {
* QueuedResourceName name =
* QueuedResourceName.of("[PROJECT]", "[LOCATION]", "[QUEUED_RESOURCE]");
* QueuedResource response = tpuClient.resetQueuedResourceAsync(name).get();
* }
* }</pre>
*
* @param name Required. The name of the queued resource.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<QueuedResource, OperationMetadata> resetQueuedResourceAsync(
QueuedResourceName name) {
ResetQueuedResourceRequest request =
ResetQueuedResourceRequest.newBuilder()
.setName(name == null ? null : name.toString())
.build();
return resetQueuedResourceAsync(request);
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Resets a QueuedResource TPU instance
*
* <p>Sample code:
*
* <pre>{@code
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (TpuClient tpuClient = TpuClient.create()) {
* String name =
* QueuedResourceName.of("[PROJECT]", "[LOCATION]", "[QUEUED_RESOURCE]").toString();
* QueuedResource response = tpuClient.resetQueuedResourceAsync(name).get();
* }
* }</pre>
*
* @param name Required. The name of the queued resource.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<QueuedResource, OperationMetadata> resetQueuedResourceAsync(
String name) {
ResetQueuedResourceRequest request =
ResetQueuedResourceRequest.newBuilder().setName(name).build();
return resetQueuedResourceAsync(request);
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Resets a QueuedResource TPU instance
*
* <p>Sample code:
*
* <pre>{@code
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (TpuClient tpuClient = TpuClient.create()) {
* ResetQueuedResourceRequest request =
* ResetQueuedResourceRequest.newBuilder()
* .setName(
* QueuedResourceName.of("[PROJECT]", "[LOCATION]", "[QUEUED_RESOURCE]").toString())
* .build();
* QueuedResource response = tpuClient.resetQueuedResourceAsync(request).get();
* }
* }</pre>
*
* @param request The request object containing all of the parameters for the API call.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<QueuedResource, OperationMetadata> resetQueuedResourceAsync(
ResetQueuedResourceRequest request) {
return resetQueuedResourceOperationCallable().futureCall(request);
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Resets a QueuedResource TPU instance
*
* <p>Sample code:
*
* <pre>{@code
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (TpuClient tpuClient = TpuClient.create()) {
* ResetQueuedResourceRequest request =
* ResetQueuedResourceRequest.newBuilder()
* .setName(
* QueuedResourceName.of("[PROJECT]", "[LOCATION]", "[QUEUED_RESOURCE]").toString())
* .build();
* OperationFuture<QueuedResource, OperationMetadata> future =
* tpuClient.resetQueuedResourceOperationCallable().futureCall(request);
* // Do something.
* QueuedResource response = future.get();
* }
* }</pre>
*/
public final OperationCallable<ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationCallable() {
return stub.resetQueuedResourceOperationCallable();
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Resets a QueuedResource TPU instance
*
* <p>Sample code:
*
* <pre>{@code
* // This snippet has been automatically generated and should be regarded as a code template only.
* // It will require modifications to work:
* // - It may require correct/in-range values for request initialization.
* // - It may require specifying regional endpoints when creating the service client as shown in
* // https://cloud.google.com/java/docs/setup#configure_endpoints_for_the_client_library
* try (TpuClient tpuClient = TpuClient.create()) {
* ResetQueuedResourceRequest request =
* ResetQueuedResourceRequest.newBuilder()
* .setName(
* QueuedResourceName.of("[PROJECT]", "[LOCATION]", "[QUEUED_RESOURCE]").toString())
* .build();
* ApiFuture<Operation> future = tpuClient.resetQueuedResourceCallable().futureCall(request);
* // Do something.
* Operation response = future.get();
* }
* }</pre>
*/
public final UnaryCallable<ResetQueuedResourceRequest, Operation> resetQueuedResourceCallable() {
return stub.resetQueuedResourceCallable();
}

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Generates the Cloud TPU service identity for the project.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,6 @@ public UnaryCallSettings<DeleteQueuedResourceRequest, Operation> deleteQueuedRes
return ((TpuStubSettings) getStubSettings()).deleteQueuedResourceOperationSettings();
}

/** Returns the object with the settings used for calls to resetQueuedResource. */
public UnaryCallSettings<ResetQueuedResourceRequest, Operation> resetQueuedResourceSettings() {
return ((TpuStubSettings) getStubSettings()).resetQueuedResourceSettings();
}

/** Returns the object with the settings used for calls to resetQueuedResource. */
public OperationCallSettings<ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationSettings() {
return ((TpuStubSettings) getStubSettings()).resetQueuedResourceOperationSettings();
}

/** Returns the object with the settings used for calls to generateServiceIdentity. */
public UnaryCallSettings<GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentitySettings() {
Expand Down Expand Up @@ -461,19 +450,6 @@ public UnaryCallSettings.Builder<UpdateNodeRequest, Operation> updateNodeSetting
return getStubSettingsBuilder().deleteQueuedResourceOperationSettings();
}

/** Returns the builder for the settings used for calls to resetQueuedResource. */
public UnaryCallSettings.Builder<ResetQueuedResourceRequest, Operation>
resetQueuedResourceSettings() {
return getStubSettingsBuilder().resetQueuedResourceSettings();
}

/** Returns the builder for the settings used for calls to resetQueuedResource. */
public OperationCallSettings.Builder<
ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationSettings() {
return getStubSettingsBuilder().resetQueuedResourceOperationSettings();
}

/** Returns the builder for the settings used for calls to generateServiceIdentity. */
public UnaryCallSettings.Builder<
GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@
"ListRuntimeVersions": {
"methods": ["listRuntimeVersions", "listRuntimeVersions", "listRuntimeVersions", "listRuntimeVersionsPagedCallable", "listRuntimeVersionsCallable"]
},
"ResetQueuedResource": {
"methods": ["resetQueuedResourceAsync", "resetQueuedResourceAsync", "resetQueuedResourceAsync", "resetQueuedResourceOperationCallable", "resetQueuedResourceCallable"]
},
"SimulateMaintenanceEvent": {
"methods": ["simulateMaintenanceEventAsync", "simulateMaintenanceEventOperationCallable", "simulateMaintenanceEventCallable"]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
import com.google.cloud.tpu.v2alpha1.Node;
import com.google.cloud.tpu.v2alpha1.OperationMetadata;
import com.google.cloud.tpu.v2alpha1.QueuedResource;
import com.google.cloud.tpu.v2alpha1.ResetQueuedResourceRequest;
import com.google.cloud.tpu.v2alpha1.RuntimeVersion;
import com.google.cloud.tpu.v2alpha1.SimulateMaintenanceEventRequest;
import com.google.cloud.tpu.v2alpha1.StartNodeRequest;
Expand Down Expand Up @@ -181,16 +180,6 @@ public class GrpcTpuStub extends TpuStub {
.setResponseMarshaller(ProtoUtils.marshaller(Operation.getDefaultInstance()))
.build();

private static final MethodDescriptor<ResetQueuedResourceRequest, Operation>
resetQueuedResourceMethodDescriptor =
MethodDescriptor.<ResetQueuedResourceRequest, Operation>newBuilder()
.setType(MethodDescriptor.MethodType.UNARY)
.setFullMethodName("google.cloud.tpu.v2alpha1.Tpu/ResetQueuedResource")
.setRequestMarshaller(
ProtoUtils.marshaller(ResetQueuedResourceRequest.getDefaultInstance()))
.setResponseMarshaller(ProtoUtils.marshaller(Operation.getDefaultInstance()))
.build();

private static final MethodDescriptor<
GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentityMethodDescriptor =
Expand Down Expand Up @@ -315,9 +304,6 @@ public class GrpcTpuStub extends TpuStub {
private final UnaryCallable<DeleteQueuedResourceRequest, Operation> deleteQueuedResourceCallable;
private final OperationCallable<DeleteQueuedResourceRequest, QueuedResource, OperationMetadata>
deleteQueuedResourceOperationCallable;
private final UnaryCallable<ResetQueuedResourceRequest, Operation> resetQueuedResourceCallable;
private final OperationCallable<ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationCallable;
private final UnaryCallable<GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentityCallable;
private final UnaryCallable<ListAcceleratorTypesRequest, ListAcceleratorTypesResponse>
Expand Down Expand Up @@ -490,16 +476,6 @@ protected GrpcTpuStub(
return params.build();
})
.build();
GrpcCallSettings<ResetQueuedResourceRequest, Operation> resetQueuedResourceTransportSettings =
GrpcCallSettings.<ResetQueuedResourceRequest, Operation>newBuilder()
.setMethodDescriptor(resetQueuedResourceMethodDescriptor)
.setParamsExtractor(
request -> {
ImmutableMap.Builder<String, String> params = ImmutableMap.builder();
params.put("name", String.valueOf(request.getName()));
return params.build();
})
.build();
GrpcCallSettings<GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentityTransportSettings =
GrpcCallSettings
Expand Down Expand Up @@ -689,17 +665,6 @@ protected GrpcTpuStub(
settings.deleteQueuedResourceOperationSettings(),
clientContext,
operationsStub);
this.resetQueuedResourceCallable =
callableFactory.createUnaryCallable(
resetQueuedResourceTransportSettings,
settings.resetQueuedResourceSettings(),
clientContext);
this.resetQueuedResourceOperationCallable =
callableFactory.createOperationCallable(
resetQueuedResourceTransportSettings,
settings.resetQueuedResourceOperationSettings(),
clientContext,
operationsStub);
this.generateServiceIdentityCallable =
callableFactory.createUnaryCallable(
generateServiceIdentityTransportSettings,
Expand Down Expand Up @@ -876,17 +841,6 @@ public UnaryCallable<DeleteQueuedResourceRequest, Operation> deleteQueuedResourc
return deleteQueuedResourceOperationCallable;
}

@Override
public UnaryCallable<ResetQueuedResourceRequest, Operation> resetQueuedResourceCallable() {
return resetQueuedResourceCallable;
}

@Override
public OperationCallable<ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationCallable() {
return resetQueuedResourceOperationCallable;
}

@Override
public UnaryCallable<GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentityCallable() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
import com.google.cloud.tpu.v2alpha1.Node;
import com.google.cloud.tpu.v2alpha1.OperationMetadata;
import com.google.cloud.tpu.v2alpha1.QueuedResource;
import com.google.cloud.tpu.v2alpha1.ResetQueuedResourceRequest;
import com.google.cloud.tpu.v2alpha1.RuntimeVersion;
import com.google.cloud.tpu.v2alpha1.SimulateMaintenanceEventRequest;
import com.google.cloud.tpu.v2alpha1.StartNodeRequest;
Expand Down Expand Up @@ -168,16 +167,6 @@ public UnaryCallable<DeleteQueuedResourceRequest, Operation> deleteQueuedResourc
throw new UnsupportedOperationException("Not implemented: deleteQueuedResourceCallable()");
}

public OperationCallable<ResetQueuedResourceRequest, QueuedResource, OperationMetadata>
resetQueuedResourceOperationCallable() {
throw new UnsupportedOperationException(
"Not implemented: resetQueuedResourceOperationCallable()");
}

public UnaryCallable<ResetQueuedResourceRequest, Operation> resetQueuedResourceCallable() {
throw new UnsupportedOperationException("Not implemented: resetQueuedResourceCallable()");
}

public UnaryCallable<GenerateServiceIdentityRequest, GenerateServiceIdentityResponse>
generateServiceIdentityCallable() {
throw new UnsupportedOperationException("Not implemented: generateServiceIdentityCallable()");
Expand Down
Loading