feat: Implement ES256 for JWT verification #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
changed the title
arithmetic1728
force-pushed
the
add-ec256-crypto
branch
from
7a76704 to
ec189f2
Compare
arithmetic1728
force-pushed
the
add-ec256-crypto
branch
from
ec189f2 to
ffc4f9c
Compare
arithmetic1728
changed the title
bshaffer
reviewed
Mar 25, 2020
There was a problem hiding this comment.
This all looks fantastic. One clarification question, and also, seems like we should add a bit to the ID Token docs
Yes. docs are now added. |
bshaffer
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336
Closes #157