-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move context from namespace to class scope #1605
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
- Coverage 98.44% 98.43% -0.02%
==========================================
Files 2 2
Lines 258 256 -2
Branches 2 2
==========================================
- Hits 254 252 -2
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Have you run the generator, and verified the resulting changes? Could you do that, and add the results as a follow-up commit?
@JustinBeckwith updated PR with generated files. |
superseded by #1660 |
Fixes #1594 Moving context variable from namespace to class scope.