Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: keep GoogleUtils (#1467) #1488

Closed
wants to merge 1 commit into from
Closed

revert: keep GoogleUtils (#1467) #1488

wants to merge 1 commit into from

Conversation

chingor13
Copy link
Collaborator

This reverts commit b70e8ef.

#1487

@chingor13 chingor13 requested a review from elharo February 10, 2020 18:59
@chingor13 chingor13 requested a review from a team as a code owner February 10, 2020 18:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2020
elharo
elharo suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being reverted?

@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 10, 2020
elharo
elharo suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reversion will regress #1450 which was a bug at runtime. This at best fixes an issue for some compile time uses.

@elharo
Copy link
Contributor

elharo commented Feb 14, 2020

alternate solution found based on R8 so this is moot

@elharo elharo closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo requested changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chingor13 @elharo @kolea2 @googlebot