Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vazirmatn: Version 32.0.0 added #4352

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Vazirmatn: Version 32.0.0 added #4352

merged 3 commits into from
Mar 18, 2022

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Mar 9, 2022

09dad74: [gftools-packager] Vazirmatn: Version 32.0.0 added

@yanone yanone linked an issue Mar 9, 2022 that may be closed by this pull request
Add Vazir #2975
Closed
@yanone yanone mentioned this pull request Mar 9, 2022
Closed
@gf-bot
Copy link

gf-bot commented Mar 9, 2022

Fontbakery report

Fontbakery version: 0.8.7

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table.
* [com.google.fonts/check/STAT/axis_order](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[23] Vazirmatn[wght].ttf
🔥 FAIL: Check upstream.yaml file contains all required fields
* [com.google.fonts/check/repo/upstream_yaml_has_required_fields](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/upstream_yaml_has_required_fields)
  • 🔥 FAIL The upstream.yaml file is missing the following fields: ['repository_url'] [code: missing-fields]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks.
* [com.google.fonts/check/dotted_circle](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
    • hook
    • tildecomb
    • acutecomb
    • uni030F
    • gravecomb
    • And dotbelow [code: unattached-dotted-circle-marks]
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak.
* [com.google.fonts/check/description/eof_linebreak](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/eof_linebreak)
  • ⚠ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
⚠ WARN: Checking OS/2 achVendID.
* [com.google.fonts/check/vendor_id](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/vendor_id)
  • ⚠ WARN OS/2 VendorID value ' ' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
⚠ WARN: Description strings in the name table must not exceed 200 characters.
* [com.google.fonts/check/name/description_max_length](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/description_max_length)
  • ⚠ WARN A few name table entries with ID=10 (NameID.DESCRIPTION) are longer than 200 characters. Please check whether those entries are copyright notices mistakenly stored in the description string entries by a bug in an old FontLab version. If that's the case, then such copyright notices must be removed from these entries. [code: too-long]
⚠ WARN: Are there caret positions declared for every ligature?
* [com.google.fonts/check/ligature_carets](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/ligature_carets)
  • ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠ WARN: Is there kerning info for non-ligated sequences?
* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences)

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + l
    • l + l
    • uniFEDF + uniFB51
    • uniFB51 + uniFE82
    • uniFE82 + uniFE84
    • uniFE84 + uniFE88
    • uniFEE0 + uniFB51
    • space + uni064B
    • uni064B + uni064C
    • uni064C + uni064D
    • uni064D + uni064E
    • uni064E + uni064F
    • uni064F + uni0650
    • uni0650 + uni0651
    • uni0651 + uni0652
    • uni0627 + uniFEDF
    • uniFEDF + uniFEE0
    • uniFEE0 + uniFEEA
    • uniFEEA + uni0653
    • uni0653 + uni0654
    • uni0654 + uni0655
    • uni0640 + uni064B
    • uni064B + uni064E
    • uni0647 + uni0654
    • uni0648 + uni0654
    • uni064A + uni0654
    • uniFEEA + uni0654

    [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts
* [com.google.fonts/check/repo/vf_has_static_fonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/vf_has_static_fonts)
  • ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
* [com.google.fonts/check/metadata/designer_profiles](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/designer_profiles)
  • ⚠ WARN It seems that Saber Rastikerdar is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
* [com.google.fonts/check/meta/script_lang_tags](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/meta/script_lang_tags)
  • ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠ WARN: Font contains '.notdef' as its first glyph?
* [com.google.fonts/check/mandatory_glyphs](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/mandatory_glyphs)
  • ⚠ WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
⚠ WARN: Font has **proper** whitespace glyph names?
* [com.google.fonts/check/whitespace_glyphnames](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/whitespace_glyphnames)
  • ⚠ WARN Glyph 0x00A0 is called "nbspace": Change to "uni00A0" [code: not-recommended-00a0]
⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
* [com.google.fonts/check/xavgcharwidth](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/os2.html#com.google.fonts/check/xavgcharwidth)
  • ⚠ WARN OS/2 xAvgCharWidth is 1159 but it should be 1132 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]
⚠ WARN: Check mark characters are in GDEF mark glyph class.
* [com.google.fonts/check/gdef_mark_chars](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/gdef.html#com.google.fonts/check/gdef_mark_chars)
  • ⚠ WARN The following mark characters could be in the GDEF mark glyph class:
    uni0658 (U+0658) [code: mark-chars]
⚠ WARN: Are there any misaligned on-curve points?
* [com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/.html#com.google.fonts/check/outline_alignment_miss)
  • ⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • exclam (U+0021): X=278.0,Y=1.0 (should be at baseline 0?)
    • dollar (U+0024): X=407.0,Y=2.0 (should be at baseline 0?)
    • nine (U+0039): X=324.0,Y=-2.0 (should be at baseline 0?)
    • nine (U+0039): X=305.0,Y=-2.0 (should be at baseline 0?)
    • colon (U+003A): X=278.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=971.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=136.0,Y=1.0 (should be at baseline 0?)
    • mu (U+00B5): X=432.5,Y=-1.5 (should be at baseline 0?)
    • Atilde (U+00C3): X=472.5,Y=1636.0 (should be at cap-height 1638?)
    • Ntilde (U+00D1): X=526.5,Y=1636.0 (should be at cap-height 1638?) and 83 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL?
* [com.google.fonts/check/description/git_url](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact.
* [com.google.fonts/check/hinting_impact](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/vazirmatn/Vazirmatn[wght].ttf
Dehinted Size 234.6kb
Hinted Size 280.1kb
Increase 45.5kb
Change 19.4 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied?
* [com.google.fonts/check/old_ttfautohint](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 32.0.0'] [code: version-not-detected]
ℹ INFO: EPAR table present in font?
* [com.google.fonts/check/epar](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* [com.google.fonts/check/gasp](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning.
* [com.google.fonts/check/fontv](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 32.0.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Font contains all required tables?
* [com.google.fonts/check/required_tables](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/required_tables)
  • ℹ INFO This font contains the following optional tables:
    • cvt
    • fpgm
    • loca
    • prep
    • GPOS
    • GSUB
    • And gasp [code: optional-tables]
ℹ INFO: List all superfamily filepaths
* [com.google.fonts/check/superfamily/list](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/vazirmatn [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 13 52 9 147 0
0% 1% 6% 23% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone
Copy link
Collaborator Author

yanone commented Mar 9, 2022

Updated

Vazirmatn: Version 32.0.0 added

1d756d2: [gftools-packager] Vazirmatn: Version 32.0.0 added

@yanone yanone force-pushed the gftools_packager_ofl_vazirmatn branch from 09dad74 to 1d756d2 Compare March 9, 2022 14:56
@yanone
Copy link
Collaborator Author

yanone commented Mar 9, 2022

I told the author to put in a good work about the dotted circle check. He did his work ahead of the new requirement, and to my knowledge, it's never used for Arabic

@thlinard
Copy link
Contributor

thlinard commented Mar 9, 2022 •
edited
Loading

I told the author to put in a good work about the dotted circle check. He did his work ahead of the new requirement, and to my knowledge, it's never used for Arabic

Not quite. See "For the fallback mechanism to work properly, an Arabic OTL font should contain a glyph for the dotted circle (U+25CC)" https://docs.microsoft.com/en-us/typography/script-development/arabic. Also https://github.com/googlefonts/noto-fonts/issues/2248 or #2974.

@gf-bot
Copy link

gf-bot commented Mar 9, 2022

Fontbakery report

Fontbakery version: 0.8.7

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table.
* [com.google.fonts/check/STAT/axis_order](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[23] Vazirmatn[wght].ttf
🔥 FAIL: Check upstream.yaml file contains all required fields
* [com.google.fonts/check/repo/upstream_yaml_has_required_fields](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/upstream_yaml_has_required_fields)
  • 🔥 FAIL The upstream.yaml file is missing the following fields: ['repository_url'] [code: missing-fields]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks.
* [com.google.fonts/check/dotted_circle](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
    • dotbelow
    • acutecomb
    • gravecomb
    • hook
    • uni030F
    • And tildecomb [code: unattached-dotted-circle-marks]
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak.
* [com.google.fonts/check/description/eof_linebreak](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/eof_linebreak)
  • ⚠ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
⚠ WARN: Checking OS/2 achVendID.
* [com.google.fonts/check/vendor_id](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/vendor_id)
  • ⚠ WARN OS/2 VendorID value ' ' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
⚠ WARN: Description strings in the name table must not exceed 200 characters.
* [com.google.fonts/check/name/description_max_length](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/description_max_length)
  • ⚠ WARN A few name table entries with ID=10 (NameID.DESCRIPTION) are longer than 200 characters. Please check whether those entries are copyright notices mistakenly stored in the description string entries by a bug in an old FontLab version. If that's the case, then such copyright notices must be removed from these entries. [code: too-long]
⚠ WARN: Are there caret positions declared for every ligature?
* [com.google.fonts/check/ligature_carets](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/ligature_carets)
  • ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠ WARN: Is there kerning info for non-ligated sequences?
* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences)

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + l
    • l + l
    • uniFEDF + uniFB51
    • uniFB51 + uniFE82
    • uniFE82 + uniFE84
    • uniFE84 + uniFE88
    • uniFEE0 + uniFB51
    • space + uni064B
    • uni064B + uni064C
    • uni064C + uni064D
    • uni064D + uni064E
    • uni064E + uni064F
    • uni064F + uni0650
    • uni0650 + uni0651
    • uni0651 + uni0652
    • uni0627 + uniFEDF
    • uniFEDF + uniFEE0
    • uniFEE0 + uniFEEA
    • uniFEEA + uni0653
    • uni0653 + uni0654
    • uni0654 + uni0655
    • uni0640 + uni064B
    • uni064B + uni064E
    • uni0647 + uni0654
    • uni0648 + uni0654
    • uni064A + uni0654
    • uniFEEA + uni0654

    [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts
* [com.google.fonts/check/repo/vf_has_static_fonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/vf_has_static_fonts)
  • ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
* [com.google.fonts/check/metadata/designer_profiles](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/designer_profiles)
  • ⚠ WARN It seems that Saber Rastikerdar is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
* [com.google.fonts/check/meta/script_lang_tags](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/meta/script_lang_tags)
  • ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠ WARN: Font contains '.notdef' as its first glyph?
* [com.google.fonts/check/mandatory_glyphs](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/mandatory_glyphs)
  • ⚠ WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
⚠ WARN: Font has **proper** whitespace glyph names?
* [com.google.fonts/check/whitespace_glyphnames](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/whitespace_glyphnames)
  • ⚠ WARN Glyph 0x00A0 is called "nbspace": Change to "uni00A0" [code: not-recommended-00a0]
⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
* [com.google.fonts/check/xavgcharwidth](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/os2.html#com.google.fonts/check/xavgcharwidth)
  • ⚠ WARN OS/2 xAvgCharWidth is 1159 but it should be 1132 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]
⚠ WARN: Check mark characters are in GDEF mark glyph class.
* [com.google.fonts/check/gdef_mark_chars](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/gdef.html#com.google.fonts/check/gdef_mark_chars)
  • ⚠ WARN The following mark characters could be in the GDEF mark glyph class:
    uni0658 (U+0658) [code: mark-chars]
⚠ WARN: Are there any misaligned on-curve points?
* [com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/.html#com.google.fonts/check/outline_alignment_miss)
  • ⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • exclam (U+0021): X=278.0,Y=1.0 (should be at baseline 0?)
    • dollar (U+0024): X=407.0,Y=2.0 (should be at baseline 0?)
    • nine (U+0039): X=324.0,Y=-2.0 (should be at baseline 0?)
    • nine (U+0039): X=305.0,Y=-2.0 (should be at baseline 0?)
    • colon (U+003A): X=278.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=971.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=136.0,Y=1.0 (should be at baseline 0?)
    • mu (U+00B5): X=432.5,Y=-1.5 (should be at baseline 0?)
    • Atilde (U+00C3): X=472.5,Y=1636.0 (should be at cap-height 1638?)
    • Ntilde (U+00D1): X=526.5,Y=1636.0 (should be at cap-height 1638?) and 83 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL?
* [com.google.fonts/check/description/git_url](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact.
* [com.google.fonts/check/hinting_impact](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/vazirmatn/Vazirmatn[wght].ttf
Dehinted Size 234.6kb
Hinted Size 280.1kb
Increase 45.5kb
Change 19.4 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied?
* [com.google.fonts/check/old_ttfautohint](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 32.0.0'] [code: version-not-detected]
ℹ INFO: EPAR table present in font?
* [com.google.fonts/check/epar](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* [com.google.fonts/check/gasp](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning.
* [com.google.fonts/check/fontv](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 32.0.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Font contains all required tables?
* [com.google.fonts/check/required_tables](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/required_tables)
  • ℹ INFO This font contains the following optional tables:
    • cvt
    • fpgm
    • loca
    • prep
    • GPOS
    • GSUB
    • And gasp [code: optional-tables]
ℹ INFO: List all superfamily filepaths
* [com.google.fonts/check/superfamily/list](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/vazirmatn [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 13 52 9 147 0
0% 1% 6% 23% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone
Copy link
Collaborator Author

yanone commented Mar 9, 2022

Anyway. The font contains the dotted circle glyph, just not the anchors need to properly attach marks to it. So it'll work, and the layout engine will estimates the anchor placement.

@rastikerdar
Copy link

Sorry, there is a serious problem in v32.0.0 about kerning in numbers. Any chance to replace the current file 32.0 with new 32.1 before merging?
https://github.com/rastikerdar/vazirmatn/blob/master/fonts/variable/Vazirmatn%5Bwght%5D.ttf
I apologize for the inconvenience. That issue occurred due to different displaying in windows 7, 10, Gnu/Linux and Android. So I removed the kerning tables for numbers. This is the only change.
rastikerdar/vazirmatn#244
@yanone

@yanone
Copy link
Collaborator Author

yanone commented Mar 16, 2022

Sure, I'll PR the new files. Thank you.

@yanone
Copy link
Collaborator Author

yanone commented Mar 16, 2022

Updated

Vazirmatn: Version 32.1 added

caa7b00: [gftools-packager] Vazirmatn: Version 32.1 added

@yanone yanone force-pushed the gftools_packager_ofl_vazirmatn branch from 1d756d2 to caa7b00 Compare March 16, 2022 06:15
@gf-bot
Copy link

gf-bot commented Mar 18, 2022

Fontbakery report

Fontbakery version: 0.8.7

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table.
* [com.google.fonts/check/STAT/axis_order](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[30] Vazirmatn[wght].ttf
💔 ERROR: METADATA.pb: Fontfamily is listed on Google Fonts API?
* [com.google.fonts/check/metadata/listed_on_gfonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/listed_on_gfonts)
  • 💔 ERROR The check FontBakeryCheck:com.google.fonts/check/metadata/listed_on_gfonts had an error: FailedConditionError: The condition FontBakeryCondition:listed_on_gfonts_api had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Check METADATA.pb includes production subsets.
* [com.google.fonts/check/metadata/includes_production_subsets](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/includes_production_subsets)
  • 💔 ERROR The condition FontBakeryCondition:production_metadata had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Version number has increased since previous release on Google Fonts?
* [com.google.fonts/check/version_bump](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/version_bump)
  • 💔 ERROR The condition FontBakeryCondition:api_gfonts_ttFont had an error: FailedConditionError: The condition FontBakeryCondition:remote_styles had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Glyphs are similiar to Google Fonts version?
* [com.google.fonts/check/production_glyphs_similarity](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/production_glyphs_similarity)
  • 💔 ERROR The condition FontBakeryCondition:api_gfonts_ttFont had an error: FailedConditionError: The condition FontBakeryCondition:remote_styles had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
* [com.google.fonts/check/vertical_metrics_regressions](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/vertical_metrics_regressions)
  • 💔 ERROR The condition FontBakeryCondition:regular_remote_style had an error: FailedConditionError: The condition FontBakeryCondition:remote_styles had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Check font follows the Google Fonts CJK vertical metric schema
* [com.google.fonts/check/cjk_vertical_metrics](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/cjk_vertical_metrics)
  • 💔 ERROR The condition FontBakeryCondition:remote_styles had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
💔 ERROR: Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
* [com.google.fonts/check/cjk_vertical_metrics_regressions](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/cjk_vertical_metrics_regressions)
  • 💔 ERROR The condition FontBakeryCondition:regular_remote_style had an error: FailedConditionError: The condition FontBakeryCondition:remote_styles had an error: JSONDecodeError: Expecting value: line 1 column 1 (char 0)
🔥 FAIL: Check upstream.yaml file contains all required fields
* [com.google.fonts/check/repo/upstream_yaml_has_required_fields](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/upstream_yaml_has_required_fields)
  • 🔥 FAIL The upstream.yaml file is missing the following fields: ['repository_url'] [code: missing-fields]
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
* [com.google.fonts/check/metadata/designer_profiles](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/designer_profiles)
  • 🔥 FAIL Designer Saber Rastikerdar still does not have an avatar image. Please provide one. [code: missing-avatar]
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks.
* [com.google.fonts/check/dotted_circle](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
    • gravecomb
    • acutecomb
    • tildecomb
    • dotbelow
    • uni030F
    • And hook [code: unattached-dotted-circle-marks]
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak.
* [com.google.fonts/check/description/eof_linebreak](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/eof_linebreak)
  • ⚠ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
⚠ WARN: Checking OS/2 achVendID.
* [com.google.fonts/check/vendor_id](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/vendor_id)
  • ⚠ WARN OS/2 VendorID value ' ' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
⚠ WARN: Description strings in the name table must not exceed 200 characters.
* [com.google.fonts/check/name/description_max_length](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/description_max_length)
  • ⚠ WARN A few name table entries with ID=10 (NameID.DESCRIPTION) are longer than 200 characters. Please check whether those entries are copyright notices mistakenly stored in the description string entries by a bug in an old FontLab version. If that's the case, then such copyright notices must be removed from these entries. [code: too-long]
⚠ WARN: Are there caret positions declared for every ligature?
* [com.google.fonts/check/ligature_carets](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/ligature_carets)
  • ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠ WARN: Is there kerning info for non-ligated sequences?
* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences)

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + l
    • l + l
    • uniFEDF + uniFB51
    • uniFB51 + uniFE82
    • uniFE82 + uniFE84
    • uniFE84 + uniFE88
    • uniFEE0 + uniFB51
    • space + uni064B
    • uni064B + uni064C
    • uni064C + uni064D
    • uni064D + uni064E
    • uni064E + uni064F
    • uni064F + uni0650
    • uni0650 + uni0651
    • uni0651 + uni0652
    • uni0627 + uniFEDF
    • uniFEDF + uniFEE0
    • uniFEE0 + uniFEEA
    • uniFEEA + uni0653
    • uni0653 + uni0654
    • uni0654 + uni0655
    • uni0640 + uni064B
    • uni064B + uni064E
    • uni0647 + uni0654
    • uni0648 + uni0654
    • uni064A + uni0654
    • uniFEEA + uni0654

    [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts
* [com.google.fonts/check/repo/vf_has_static_fonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/vf_has_static_fonts)
  • ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
* [com.google.fonts/check/meta/script_lang_tags](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/meta/script_lang_tags)
  • ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠ WARN: Font contains '.notdef' as its first glyph?
* [com.google.fonts/check/mandatory_glyphs](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/mandatory_glyphs)
  • ⚠ WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
⚠ WARN: Font has **proper** whitespace glyph names?
* [com.google.fonts/check/whitespace_glyphnames](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/whitespace_glyphnames)
  • ⚠ WARN Glyph 0x00A0 is called "nbspace": Change to "uni00A0" [code: not-recommended-00a0]
⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
* [com.google.fonts/check/xavgcharwidth](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/os2.html#com.google.fonts/check/xavgcharwidth)
  • ⚠ WARN OS/2 xAvgCharWidth is 1159 but it should be 1132 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]
⚠ WARN: Check mark characters are in GDEF mark glyph class.
* [com.google.fonts/check/gdef_mark_chars](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/gdef.html#com.google.fonts/check/gdef_mark_chars)
  • ⚠ WARN The following mark characters could be in the GDEF mark glyph class:
    uni0658 (U+0658) [code: mark-chars]
⚠ WARN: Are there any misaligned on-curve points?
* [com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/.html#com.google.fonts/check/outline_alignment_miss)
  • ⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • exclam (U+0021): X=278.0,Y=1.0 (should be at baseline 0?)
    • dollar (U+0024): X=407.0,Y=2.0 (should be at baseline 0?)
    • nine (U+0039): X=324.0,Y=-2.0 (should be at baseline 0?)
    • nine (U+0039): X=305.0,Y=-2.0 (should be at baseline 0?)
    • colon (U+003A): X=278.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=971.0,Y=1.0 (should be at baseline 0?)
    • plusminus (U+00B1): X=136.0,Y=1.0 (should be at baseline 0?)
    • mu (U+00B5): X=432.5,Y=-1.5 (should be at baseline 0?)
    • Atilde (U+00C3): X=472.5,Y=1636.0 (should be at cap-height 1638?)
    • Ntilde (U+00D1): X=526.5,Y=1636.0 (should be at cap-height 1638?) and 83 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL?
* [com.google.fonts/check/description/git_url](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact.
* [com.google.fonts/check/hinting_impact](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/vazirmatn/Vazirmatn[wght].ttf
Dehinted Size 234.3kb
Hinted Size 279.8kb
Increase 45.5kb
Change 19.4 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied?
* [com.google.fonts/check/old_ttfautohint](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 32.1'] [code: version-not-detected]
ℹ INFO: EPAR table present in font?
* [com.google.fonts/check/epar](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* [com.google.fonts/check/gasp](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning.
* [com.google.fonts/check/fontv](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 32.1"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Font contains all required tables?
* [com.google.fonts/check/required_tables](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/required_tables)
  • ℹ INFO This font contains the following optional tables:
    • cvt
    • fpgm
    • loca
    • prep
    • GPOS
    • GSUB
    • And gasp [code: optional-tables]
ℹ INFO: List all superfamily filepaths
* [com.google.fonts/check/superfamily/list](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/vazirmatn [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
7 3 12 45 9 147 0
3% 1% 5% 20% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 3c908f7 into main Mar 18, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_vazirmatn branch March 18, 2022 14:23
@rastikerdar
Copy link

Thanks for publishing Vazirmatn but there are two problems: Kerning and hinting.
I don't see any issue in the file uploaded by @yanone but as you can see in the picture all the kerning values has been set to zero during the font generation by fonts.google.com (why?!). I have used the fontmake tool from Google for generating all weights with no problem In the main repository of Vazirmatn. The very odd point is that when you check the preview in fonts.google.com with Google Chrome browser, kerning values are correct because it seems that the files are different when you see them in Firefox or when you download the family separately. Looks like that the fonts.google.com serves different files for each browser. Anyway kernings are lost by fonts.google.com!

googlefonts-vazirmatn-kerning-issue

googlefonts-vazirmatn-kerning-issue2

The second problem is about hinting. I used ttfautohint for hinting and everything looked fine in the main repository but as you can see in the picture hinting has been destroyed by fonts.google.com!

googlefonts-vazirmatn-hinting-issue

You can compare files by adding them on this page:
https://rastikerdar.github.io/vazirmatn/en/lab

Pictures are in Windows 10

@yanone
Copy link
Collaborator Author

yanone commented Apr 1, 2022

Yes, it's possible that Google Fonts API serves different fonts for different browsers. The engineers responsible for this are a different team.

@davelab6 Please advise on how to proceed. It appears this needs to be raised to the API engineers.

@RosaWagner RosaWagner added the -- Needs manager's opinion from upper level label Apr 1, 2022
@RosaWagner RosaWagner mentioned this pull request Apr 1, 2022
Closed
@RosaWagner RosaWagner removed the -- Needs manager's opinion from upper level label Apr 1, 2022
@RosaWagner
Copy link
Contributor

I opened a new issue, better to discuss the matter there #4463

@RosaWagner RosaWagner added II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts --- Live Font is visible on API and removed --- to production labels Apr 1, 2022
@rastikerdar
Copy link

Hello
Sorry, can i request an update for Vazirmatn? Since the latest version on GF (32.102) several bug fixes and design improvements have been made:

  • Added Jawi letters
  • Added U+06C8 (ۈ) of Uyghur language
  • Fixed wrong interpolation of endofproof
  • Improved typeface design
  • Fixed bugs in some glyphs
  • Added missing alternatives for some glyphs
  • Improved kerning

Details of changes:
https://github.com/rastikerdar/vazirmatn/releases

The white area is the old version of Vazirmatn:
vazirmatn33

https://github.com/rastikerdar/vazirmatn/tree/master/fonts/variable
Thanks in advance

@RosaWagner
Copy link
Contributor

Can you open an issue in the issue tracker ("update" template)? https://github.com/google/fonts/issues

@rastikerdar rastikerdar mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
--- Live Font is visible on API I New Font II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vazir
5 participants
@yanone @gf-bot @thlinard @rastikerdar @RosaWagner