update to mdbook-0.4.44 and sync book.js and index.hbs #2610
+31
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is more difficult and needs some additional work. Cargo install --locked does not use the Cargo.lock from this repository but the one of the lastest version of the crate - so this is not what we want (for now). There will be a separate work item (#2620) for creating an install script with locked versions to replicate what we have in the CI environment so developers can use the same versions. Then we can update the install script and update everything. |
- reran mdbook init --theme - keep playground improvements - keep language selector and suggest edit / edit to translation button text - improvement: toc is in separate js file, makes html file way smaller - additionally updated to mdbook-i18n-helpers-0.3.5 relevant upstream changes that are used: - rust-lang/mdBook#2414 - rust-lang/mdBook#2421 - rust-lang/mdBook#2454 - rust-lang/mdBook#2463
michael-kerscher
force-pushed
the
mdbook-update
branch
from
fc60bba to
d6bd825
Compare
|
The output of the updated versions looks good to me and is ready for a review. |
|
Tested this myself and it seems to be in good shape! This doen't fix the issue of the speaker notes "reverting" to show the slides themselves, but we can address that separately. |
djmitche
approved these changes
Feb 6, 2025
michael-kerscher
added a commit
to michael-kerscher/comprehensive-rust
that referenced
this pull request
Feb 7, 2025
mdbook in CI pipeline is updated to mdbook-0.4.44 - reran mdbook init --theme - keep playground improvements - keep language selector and suggest edit / edit to translation button text - improvement: toc is in separate js file, makes html file way smaller - additionally updated to mdbook-i18n-helpers-0.3.5 relevant upstream changes that are used: - rust-lang/mdBook#2414 - rust-lang/mdBook#2421 - rust-lang/mdBook#2454 - rust-lang/mdBook#2463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdbook in CI pipeline is updated to mdbook-0.4.44
relevant upstream changes that are used: