Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: update summary translations #2474

Merged

Conversation

HidenoriKobayashi
Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi commented Nov 26, 2024

Update translations from SUMMARY.md.

Unfortunately, poedit changes the wrapping length of the po files and I could not get it back by changing the poedit setting for line length. I believe we won't get any more of these noisy diffs for my further changes this week.

Cancellation is the last item I modified in this PR.

@HidenoriKobayashi HidenoriKobayashi marked this pull request as ready for review November 27, 2024 06:42
Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@HidenoriKobayashi
Copy link
Collaborator Author

Thanks for the review and suggestions! Please take another look.

@HidenoriKobayashi
Copy link
Collaborator Author

@keiichiw san, could help review this again please?

Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. LGTM. Approved!

@HidenoriKobayashi HidenoriKobayashi merged commit b2576ce into google:main Dec 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants