Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split typos and formatting checks into separate workflows #1710

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

djmitche
Copy link
Collaborator

Without this it's easy for failures of one of these checks to hide failures of the other.

@@ -34,6 +34,17 @@ jobs:
with:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call here should go away now.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, you should just remove the dupliate typos check first.

@djmitche djmitche enabled auto-merge (squash) January 17, 2024 13:54
@djmitche djmitche merged commit e785962 into google:main Jan 17, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants