Partially revert #1576 #1700
Merged
Partially revert #1576 #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not going to attempt to review this since I know nothing about this new action, and in general am pretty ropey at github actions! Definitely should wait for @djmitche . |
sakex
approved these changes
Jan 15, 2024
Thanks, makes sense!
Yeah, that's fair. Dustin is out on vacation today, but luckily Alex has reviewed it. |
The GitHub action fails because it cannot run with the necessary
permissions: it requires write access to be able to post a comment,
but when triggered from a fork, the token is limited to read access.
The error is from the thollander/actions-comment-pull-request action:
No comment has been found with asked pattern. Creating a new comment.
Error: Resource not accessible by integration
The downgrading of the token is explained on:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
where “Maximum access for pull requests from public forked
repositories” says that the pull-requests permission is capped at read
in the typical case for us.
I kept the underlying functionality since we might want to use it for
something else (perhaps track the duration in the README).
Fixes the errors seen on the recent PRs: #1693, #1687, and likely
others.
mgeisler
force-pushed
the
revert-course-schedule-check
branch
from
bdad2f0 to
cc3b318
Compare
djmitche
added a commit
to djmitche/comprehensive-rust
that referenced
this pull request
Feb 8, 2024
This reverts commit 60c5a33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub action added in #1576 fails because it cannot run with the necessary permissions: it requires write access to be able to post a comment, but when triggered from a fork, the token is limited to read access.
The error is from the thollander/actions-comment-pull-request action:
The downgrading of the token is explained on:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
where “Maximum access for pull requests from public forked repositories” says that the pull-requests permission is capped at read in the typical case for us.
I kept the underlying functionality since we might want to use it for something else (perhaps track the duration in the README).
Fixes the errors seen on the recent PRs: #1693, #1687, and likely others.