-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GUI exercise with Logger #1682
Conversation
|
Thanks, I like this a lot! It makes the generics part much more focused and it shows a useful pattern.
Not sure! I just tried it here:
Ah, I know why! Wrapping of comments is an unstable Let me try to fix this! |
Without this, several of the formatting directives in our `rustfmt.toml` file won’t have any effect. This will in turn lead to mismatches between the formatting done locally and in CI. From the discussion in #1682.
I found a way to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Without this, several of the formatting directives in our `rustfmt.toml` file won’t have any effect. This will in turn lead to mismatches between the formatting done locally and in CI. This creates a dependency on `rustup`, but I think this is overall better than silently ignoring the formatting directives. From the discussion in #1682.
This should be a bit simpler, and notably
But all that hard work developing the GUI exercise is not for naught: it remains in the "Modules" segment, where students will get a chance to read some Rust code and reorganize it a little bit.
Fixes #1617.
R=mgeisler as the original author of the GUI exercise.