feat: address concurrency warnings arising from Theme
#387
Conversation
`Theme` was marked as `Sendable` in gonzalezreal#351. There's nothing wrong with this per se, but sendability is not inferred for public types, a structure is only truely `Sendable` if all of its members are `Sendable`, and most of the members of `Theme` are not `Sendable`. This patch address the sendability warnings for Theme's members that the compiler emits (regardless of `StrictConcurrency`).
|
This patch is distinguishable from #349 in that it addresses the warnings, triggered by |
| public struct BlockStyle<Configuration> { | ||
| private let body: (Configuration) -> AnyView | ||
| public struct BlockStyle<Configuration> : Sendable { | ||
| private let body: @Sendable (Configuration) -> AnyView |
There was a problem hiding this comment.
There’s a whole followup chunk of work needed to make initializers (and so on) provide a @Sendable. The functions, producing View should be bound to the @MainActor as well.
You can see that at fe5621b7af. It could be squashed onto this change or pushed later.
|
Well, this snowballed a bit – only a little extra work needed to clear out the warnings and enable |
Themewas marked asSendablein #351. There's nothing wrong with this per se, but sendability is not inferred for public types, a structure is only truelySendableif all of its members areSendable, and most of the members ofThemeare notSendable.This patch address the sendability warnings for Theme's members that the compiler emits (regardless of
StrictConcurrency).