added how we would trigger hits assuming a min hit of 0

gmmorris · Apr 17, 2020 · 9ced414 · 9ced414
1 parent faef440
commit 9ced414
Show file tree

Hide file tree

Showing 3 changed files with 84 additions and 9 deletions.
diff --git a/src/plugins/data/public/search/expressions/esaggs.ts b/src/plugins/data/public/search/expressions/esaggs.ts
@@ -32,8 +32,8 @@ import { Adapters } from '../../../../../plugins/inspector/public';
 import { IAggConfigs } from '../aggs';
 import { ISearchSource, SearchSource } from '../search_source';
 import { tabifyAggResponse } from '../tabify';
-import { Filter, Query, serializeFieldFormat, TimeRange } from '../../../common';
-import { FilterManager, getTime } from '../../query';
+import { Filter, Query, serializeFieldFormat, TimeRange, getTime } from '../../../common';
+import { FilterManager } from '../../query';
 import { getSearchService, getQueryService, getIndexPatterns } from '../../services';
 import { buildTabularInspectorData } from './build_tabular_inspector_data';
 import { getRequestInspectorStats, getResponseInspectorStats, serializeAggConfig } from './utils';

diff --git a/x-pack/plugins/alerting_builtins/server/alert_types/es_query/alert_type.test.ts b/x-pack/plugins/alerting_builtins/server/alert_types/es_query/alert_type.test.ts
@@ -7,7 +7,7 @@
 import { loggingServiceMock } from '../../../../../../src/core/server/mocks';
 import { SavedObjectsErrorHelpers } from '../../../../../../src/core/server';
 import { getAlertType } from './alert_type';
-import { pick } from 'lodash';
+import { pick, times } from 'lodash';
 import { alertsMock } from '../../../../alerting/server/mocks';
 import { Params } from './alert_type_params';
 import { FilterStateStore } from '../../../../../../src/plugins/data/common';
@@ -195,6 +195,80 @@ describe('alertType', () => {
       expect(searchOptions).toMatchObject({});
       expect(searchStrategy).toEqual('es');
     });
+
+    it('should trigger an instance of each found doc', async () => {
+      const services = createMockServicesWithEmptyResponses();
+
+      services.indexPattern.getById.mockResolvedValue(mockIndexPattern);
+
+      const params: Params = {
+        query: { query: 'dayOfWeek : * ', language: 'kuery' },
+        filters: [
+          {
+            meta: {
+              index: 'd3d7af60-4c81-11e8-b3d7-01146121b73d',
+              alias: null,
+              negate: true,
+              disabled: false,
+              type: 'phrase',
+              key: 'Carrier',
+              params: { query: 'JetBeats' },
+              controlledBy: undefined,
+              value: undefined,
+            },
+            query: { match_phrase: { Carrier: 'JetBeats' } },
+            $state: { store: FilterStateStore.APP_STATE },
+          },
+        ],
+        timefilter: { from: 'now-15m', to: 'now', mode: undefined },
+      };
+
+      const [firstDoc, secondDoc] = times(2, () => ({
+        _index: uuid.v4(),
+        _type: uuid.v4(),
+        _id: uuid.v4(),
+        _source: {},
+      }));
+      services.search.mockResolvedValue({
+        rawResponse: {
+          hits: {
+            total: 2,
+            hits: [firstDoc, secondDoc],
+          },
+        },
+      });
+
+      expect(
+        await executor({
+          alertId: uuid.v4(),
+          startedAt: new Date(),
+          previousStartedAt: null,
+          services,
+          params: params as Record<string, any>,
+          state: {},
+          spaceId: uuid.v4(),
+          name: 'name',
+          tags: [],
+          createdBy: null,
+          updatedBy: null,
+        })
+      ).toMatchObject({
+        totalLastRun: 2,
+      });
+
+      const [
+        { value: firstAlertInstanceFactory },
+        { value: secondAlertInstanceFactory },
+      ] = services.alertInstanceFactory.mock.results;
+
+      expect(services.alertInstanceFactory).toHaveBeenCalledWith(firstDoc._id);
+      expect(firstAlertInstanceFactory.replaceState).toHaveBeenCalledWith(firstDoc);
+      expect(firstAlertInstanceFactory.scheduleActions).toHaveBeenCalledWith('default');
+
+      expect(services.alertInstanceFactory).toHaveBeenCalledWith(secondDoc._id);
+      expect(secondAlertInstanceFactory.replaceState).toHaveBeenCalledWith(secondDoc);
+      expect(secondAlertInstanceFactory.scheduleActions).toHaveBeenCalledWith('default');
+    });
   });
 });
 

diff --git a/x-pack/plugins/alerting_builtins/server/alert_types/es_query/alert_type.ts b/x-pack/plugins/alerting_builtins/server/alert_types/es_query/alert_type.ts
@@ -81,12 +81,13 @@ export function getAlertType(service: ESQueryServices): AlertType {
       'es'
     )) as IEsSearchResponse;
 
-    // hits.map(hit => {
-    //   services
-    //     .alertInstanceFactory(hit._id)
-    //     .replaceState(hit)
-    //     .scheduleActions('default');
-    // });
+    hits.map(hit => {
+      services
+        .alertInstanceFactory(hit._id)
+        .replaceState(hit)
+        .scheduleActions('default');
+    });
+
     return {
       totalLastRun: total,
     };