Add SameSite Attribute to JWT and Session Cookies #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our most recent penetration test indicated most of our web apps are vulnerable to cross-site request forgeries (CSRF's), as they will accept requests from malicious third party domains, provided the proper authentication cookie (
jwt
) is passed with the request. On the client side, some browsers will readily pass along this authentication cookie with requests from malicious third party domains to our web apps.This vulnerable behavior can be stopped by adding the
SameSite=Lax
orSameSite=Strict
attribute to thejwt
andsession
cookies in the starphleet JWT overlay. GLG is already operating under some variant of the SameSite regime, as Google has already begun the process of treating all cookies asSameSite=Lax
.My review of our source code and testing of our apps indicates this approach will work, and I am staging this pull request to serve as a reference point for discussion.