Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite Attribute to JWT and Session Cookies #11

Draft
wants to merge 1 commit into
base: asg
Choose a base branch
from

Conversation

apcollier-glg
Copy link

Our most recent penetration test indicated most of our web apps are vulnerable to cross-site request forgeries (CSRF's), as they will accept requests from malicious third party domains, provided the proper authentication cookie (jwt) is passed with the request. On the client side, some browsers will readily pass along this authentication cookie with requests from malicious third party domains to our web apps.

This vulnerable behavior can be stopped by adding the SameSite=Lax or SameSite=Strict attribute to the jwt and session cookies in the starphleet JWT overlay. GLG is already operating under some variant of the SameSite regime, as Google has already begun the process of treating all cookies as SameSite=Lax.

My review of our source code and testing of our apps indicates this approach will work, and I am staging this pull request to serve as a reference point for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant