Fix not ignoring missing for pluralization (#389)

When you add a pattern for ignoring missing, it is currently not ignoring the pluralization for that pattern. This commit fixes that, by skipping plural nodes that were ignored in the configuration for `ignore_missing`. Co-authored-by: Yordan Santallana <[email protected]> Co-authored-by: Noah Prescott <[email protected]>
glebm · Sep 10, 2021 · b04a9cf · b04a9cf
1 parent d2b3ef1
commit b04a9cf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/i18n/tasks/missing_keys.rb b/lib/i18n/tasks/missing_keys.rb
@@ -65,6 +65,7 @@ def missing_plural_forest(locales, _base = base_locale)
         plural_nodes data[locale] do |node|
           children = node.children
           present_keys = Set.new(children.map { |c| c.key.to_sym })
+          next if ignore_key?(node.full_key(root: false), :missing)
           next if present_keys.superset?(required_keys)
 
           tree[node.full_key] = node.derive(

diff --git a/spec/plural_keys_spec.rb b/spec/plural_keys_spec.rb
@@ -25,13 +25,23 @@
           one: 'one',
           other: '%{count}'
         }
+      },
+
+      ignored_pattern: {
+        plural_key: {
+          other: '%{count}'
+        }
       }
     }
   end
 
   around do |ex|
     TestCodebase.setup(
-      'config/i18n-tasks.yml' => { base_locale: 'en', locales: %w[en ar] }.to_yaml,
+      'config/i18n-tasks.yml' => {
+        base_locale: 'en',
+        locales: %w[en ar],
+        ignore_missing: ['ignored_pattern.*']
+      }.to_yaml,
       'config/locales/en.yml' => { en: base_keys }.to_yaml,
       'config/locales/ar.yml' => { ar: base_keys }.to_yaml
     )