[SYCL] Fix win build conflict of math library #8230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jul 2, 2024
|
@qnixsynapse Let you know that this PR will revert warp_size=16. I will fix its bug in the next PR. |
airMeng
approved these changes
Jul 2, 2024
|
LGTM |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 2, 2024
* fix win build conflict of math library * fix the condition: !(win32 & SYCL) * revert warp_size=16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this PR #8006, links libm if it can be found. But this will cause a link symbol conflict with libmmdd.dll.