Remove unnecessary hacks

getsentry · Feb 21, 2025 · 000b324 · 000b324
1 parent 18a1079
commit 000b324
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs b/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs
@@ -27,7 +27,7 @@ namespace Sentry.CocoaSdk;
 
 // typedef SentryEvent * _Nullable (^SentryBeforeSendEventCallback)(SentryEvent * _Nonnull);
 [Internal]
-delegate SentryEvent? SentryBeforeSendEventCallback (SentryEvent @event);
+delegate SentryEvent SentryBeforeSendEventCallback (SentryEvent @event);
 
 // typedef id<SentrySpan> _Nullable (^SentryBeforeSendSpanCallback)(id<SentrySpan> _Nonnull);
 [Internal]

diff --git a/src/Sentry/Platforms/Cocoa/SentrySdk.cs b/src/Sentry/Platforms/Cocoa/SentrySdk.cs
@@ -135,11 +135,9 @@ private static void InitSentryCocoaSdk(SentryOptions options)
                     return evt;
 
                 var result = options.BeforeSendInternal(sentryEvent, null!);
-#pragma warning disable 8603
                 // returning null is fine - the native binding even has this set, but the tooling doesn't want to obey, so the pragma was necessary
                 if (result == null)
-                    return null;
-#pragma warning restore 8603
+                    return null!;
 
                 evt.ServerName = result.ServerName;
                 evt.Dist = result.Distribution;