ci/test-images: print docker context #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds visibility into the docker context used for building container images. While the docker context is built via a blacklist-based `.dockerignore`, this should make it easier to spot: * unwanted files creeping into docker images * context bloat
|
I mentioned this at #738 (comment), but I think I'm probably not the best person to review the script in this PR. I'm thinking that @sadiqkhoja or @lognaturel would be in a better position to take a look. |
sadiqkhoja
reviewed
Mar 26, 2025
sadiqkhoja
approved these changes
Mar 27, 2025
Was pointing to the wrong answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds visibility into the docker context used for building container images.
This should make it easier to spot:
The script can also be run locally to understand differences between local and CI docker contexts.
What has been done to verify that this works as intended?
Run locally & in CI.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should not affect users.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)