Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of
Maybe.collect
checks if the partial function is defined on the input value before calling it. This can be sub-optimal, as it causes a double evaluation of pattern matchers and guards in the partial function (once on the call topf.isDefinedAt(value)
and once on the applicationpf(value)
.Solution
Using the
applyOrElse
method allows optimized implementations ofPartialFuncion
, such as partial function literals (mentioned in https://github.com/scala/scala/blob/780d80c714354871bc5972045926b7ccd042e102/src/library/scala/PartialFunction.scala#L194) to avoid double evaluations of guards.