fix: verify that toString method returned a string

Failure happened when the toString method of a recorded value returned a non-string value (specifically null or undefined). In this case, we now fallback to safe stringify operation.
getappmap · Feb 15, 2022 · ea17330 · ea17330
1 parent 0920649
commit ea17330
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/components/serialization/default/index.mjs b/components/serialization/default/index.mjs
@@ -124,6 +124,10 @@ export default (dependencies) => {
               logDebug("%o.toString() failure >> %O", value, error);
               serial.print = apply(toString, value, noargs);
             }
+            if (typeof serial.print !== "string") {
+              logDebug("%o.toString() returned a non-string result");
+              serial.print = apply(toString, value, noargs);
+            }
           } else {
             serial.print = apply(toString, value, noargs);
           }

diff --git a/components/serialization/default/index.test.mjs b/components/serialization/default/index.test.mjs
@@ -150,6 +150,22 @@ assertDeepEqual(
     print: "[object Object]",
   },
 );
+assertDeepEqual(
+  testSerialize(
+    {
+      method: "toString",
+      "include-constructor-name": false,
+    },
+    {
+      toString: () => 123,
+    },
+  ),
+  {
+    type: "object",
+    index: 1,
+    print: "[object Object]",
+  },
+);
 // function (toString)
 assertDeepEqual(
   testSerialize(