Create light visual as child of light #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Merged
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Feb 3, 2021
ahcorde
added a commit
that referenced
this pull request
Feb 18, 2021
* Plugin to spawn lights Signed-off-by: ahcorde <[email protected]> * Improved implementation Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * quick fix Signed-off-by: ahcorde <[email protected]> * clean code Signed-off-by: ahcorde <[email protected]> * updated light enum names Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Create light visual as child of light (#608) * light visual as child of light Signed-off-by: Ian Chen <[email protected]> * remove comment Signed-off-by: Ian Chen <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * Light types as lower case Signed-off-by: ahcorde <[email protected]> * Removed macos warning Signed-off-by: ahcorde <[email protected]> * Removed warning Signed-off-by: ahcorde <[email protected]> * Removed lights visuals, added light spawner to gui.config Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * spawn directional light at the same height as the other light types Signed-off-by: ahcorde <[email protected]> * Fix gui.config Signed-off-by: ahcorde <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestions for #587
Signed-off-by: Ian Chen [email protected]