Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport mac camera floating fix #339

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Backport mac camera floating fix #339

merged 3 commits into from
Jun 14, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 14, 2021

🦟 Bug fix

Summary

Backport macOS depth camera fixes from #316, #333, #335

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

darksylinc and others added 3 commits June 14, 2021 10:50
@darksylinc @iche033
Fix floating point precision bug handling alpha channel (#332) (#333)
57c1ec2 
Fixes #332
Fixes #108

Signed-off-by: Matias N. Goldberg <[email protected]>
@iche033
Fix depth alpha (#316)
86a15c7 
* update test

Signed-off-by: Ian Chen <[email protected]>

* reenable macos test

Signed-off-by: Ian Chen <[email protected]>

* fix typo

Signed-off-by: Ian Chen <[email protected]>
@iche033
cherry pick f9f1820 and fix conflicts
3edbf33 
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 14, 2021
@iche033 iche033 mentioned this pull request Jun 14, 2021
Open
@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #339 (3edbf33) into ign-rendering3 (fbfc382) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #339   +/-   ##
===============================================
  Coverage           53.21%   53.21%           
===============================================
  Files                 131      131           
  Lines               12002    12002           
===============================================
  Hits                 6387     6387           
  Misses               5615     5615

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfc382...3edbf33. Read the comment docs.

@iche033 iche033 merged commit fe96179 into ign-rendering3 Jun 14, 2021
@iche033 iche033 deleted the backport_mac_camera_floating_fix branch June 14, 2021 20:43
@chapulina chapulina mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iche033 @ahcorde @darksylinc