-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: governance #183
feat!: governance #183
Conversation
feat: add bounties pallet
feat!: setup technical committee
pub const CENTS: Balance = DOLLARS / 100; | ||
pub const MILLICENTS: Balance = CENTS / 1_000; | ||
|
||
pub const FORTUNE: Balance = u128::MAX; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this here? (Didn't find it used anywhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to be used for disabling certain features (e.g. set for minimum candidacy bond to council)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that kick our councillor also? Or is it that once he's in he's there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant as an example, is a prevention for other accounts to submit their candidacy to council
runtime/src/lib.rs
Outdated
/// Two thirds of the technical committee can have an ExternalMajority/ExternalDefault vote | ||
/// be tabled immediately and with a shorter voting/enactment period. | ||
type FastTrackOrigin = pallet_collective::EnsureMember<AccountId, CouncilCollective>; | ||
type InstantOrigin = pallet_collective::EnsureMember<AccountId, CouncilCollective>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding sudo here possibly worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not worth discussing at this point (these fast tracks should be handled by techcomm i guess). Democracy might even be disabled for testnet, as we might want to avoid public proposals for systemic changes and leave it only for tech.comm proposals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to dig deeper into it if that is even possible
Pls update merge master |
Description
Add governance features for stakenet
Related Issue
Fixes: #166
Fixes: #174
Fixes: #181