This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one minor nit. Feel free to merge!
examples/ethers-wasm/src/lib.rs
Outdated
Comment on lines
33
to
39
/// some keys of ganache with custom seed `ethers-wasm-seed` | ||
pub const KEYS: [&str; 4] = [ | ||
"817169e55f14ede54f4fd6a4f2ab4209db14aeeb1b9972b3b28f1560af0a061a", | ||
"375715b8ced8bd9b7386ba5dc72efa518aa4379d6a4676d3e26d8f5ff5e7469c", | ||
"de7c5d8e884fbe9f0915703ff2c123f4cda56f148eb22ca46d47392acf52bcec", | ||
"0bd6bf22f84f96b39258a46ac2a7c482d0b8e1c5f8af0c07fa304a8d875158ec", | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW you can also use the Mnemonic
if you want to make this a bit more robust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used mnemonic instead.
gakonst
approved these changes
Aug 23, 2021
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Add `mockCall` cheatcode * Test that mocking works for internal calls * Add `clearMockedCalls` cheatcode * Allow mocking of entire selectors * Add `expectCall` * Don't expect selectors to be a thing * Update docs * Make clippy happy * Debugger integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Followup from #390
Solution
contract-derive-abigen
remains disabled, because wasm http requires async. however this is not a limitation to the actualabigen!
macro which doesn't get executed with wasm anyways.