fix(pending_tx): fix off by one error

gakonst · Dec 24, 2020 · 6944702 · 6944702
1 parent 56bdb84
commit 6944702
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ethers-providers/src/pending_transaction.rs b/ethers-providers/src/pending_transaction.rs
@@ -121,11 +121,12 @@ impl<'a, P: JsonRpcClient> Future for PendingTransaction<'a, P> {
 
                 // if the transaction has at least K confirmations, return the receipt
                 // (subtract 1 since the tx already has 1 conf when it's mined)
-                if current_block >= inclusion_block + *this.confirmations - 1 {
+                if current_block > inclusion_block + *this.confirmations - 1 {
                     let receipt = *receipt.clone();
                     *this.state = PendingTxState::Completed;
                     return Poll::Ready(Ok(receipt));
                 } else {
+                    tracing::trace!(tx_hash = ?this.tx_hash, "confirmations {}/{}", current_block - inclusion_block + 1, this.confirmations);
                     *this.state = PendingTxState::PausedGettingBlockNumber(receipt.clone());
                     ctx.waker().wake_by_ref();
                 }