Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message from tableview when value is null #293

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Remove message from tableview when value is null #293

merged 3 commits into from
Feb 8, 2025

Conversation

nodece
Copy link
Contributor

@nodece nodece commented Feb 7, 2025 •
edited
Loading

Fix #292

Changes

  • Remove message from tableview when value is null
  • When a message value is null, the producer should update the nullValue of message metadata, and the consumer also needs to handle the nullValue.

@nodece nodece marked this pull request as draft February 7, 2025 14:17
@nodece nodece force-pushed the fix-tableview-null-vaule branch from 5a51466 to 5982fa6 Compare February 8, 2025 03:28
@nodece nodece requested a review from Lanayx February 8, 2025 03:47
@nodece nodece marked this pull request as ready for review February 8, 2025 03:48
Lanayx
Lanayx approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Lanayx Lanayx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lanayx Lanayx merged commit 5c7e180 into fsprojects:develop Feb 8, 2025
2 checks passed
@nodece nodece deleted the fix-tableview-null-vaule branch February 9, 2025 04:00
@RobertIndie RobertIndie mentioned this pull request Feb 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lanayx Lanayx Lanayx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tombstone messages appear in tableview entries
2 participants
@nodece @Lanayx