Decompressing with Zstd set bufferSizePrecheck flag to false #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the Unwrap method in ZstdNet it checks if the compressed payload contains the size of the decompressed payload. However it is not a guarrantee that it exists in the compressed payload, causing an exception
Nikolajls
changed the title
balticore
reviewed
Mar 28, 2024
Co-authored-by: Edgaras Petovradzius <[email protected]>
Lanayx
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #257 whichs contains more information.
By calling the ZstdNet unwrap method with false for
bufferSizePrecheckmessages with Zstd compressed data that does not contain the decompressed size in the payload will still work.A test case has been added that validates it if the removal of the flag is done at some point or switch to excplit true.
We are using version
3.3.0and would really love if it is feasible to get it bumped in patch for that one :)