Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all connections are closed regardless of exception #254

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Ensure all connections are closed regardless of exception #254

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1332be
Ensure all connections are closed using finally
glebvsmir Mar 6, 2024
b770110
Execute closing of connection after catching exceptions but without f…
glebvsmir Mar 6, 2024
e85b8a0
Remove and improve extra spacing
glebvsmir Mar 6, 2024
b8a8c6c
Revert to original behavior for closing connection for any exception
glebvsmir Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Pulsar.Client/Internal/ClientCnx.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,8 +840,7 @@ and internal ClientCnx (config: PulsarClientConfiguration,
if initialConnectionTsc.TrySetException(ConnectException("Unable to initiate connection")) then
Log.Logger.LogWarning("{0} New connection was aborted", prefix)
Log.Logger.LogWarning(ex, "{0} Socket was disconnected exceptionally while reading", prefix)
post operationsMb ChannelInactive

post operationsMb ChannelInactive
Log.Logger.LogDebug("{0} readSocket stopped", prefix)
} :> Task

Expand Down
Loading