Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): set test contract address during constructor call #3654

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix(forge): set test contract address during constructor call #3654

merged 1 commit into from
Nov 10, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Nov 10, 2022

Motivation

Closes #3653

previously we only set the test contract address when the setUp function was called, via the to field of the tx.

With this fork inits inside the constructor are also supported, by deriving the address of the test contract from the CREATE transaction.

Solution

@mattsse mattsse added the T-bug Type: bug label Nov 10, 2022
@mattsse mattsse requested a review from joshieDo November 10, 2022 08:19
@rkrasiuk rkrasiuk added the C-forge Command: forge label Nov 10, 2022
@mattsse
Copy link
Member Author

mattsse commented Nov 10, 2022

failing test unrelated: gakonst/ethers-rs#1853

@mattsse mattsse merged commit d35b405 into foundry-rs:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to run tests with vm.createSelectFork
2 participants
@mattsse @rkrasiuk