Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor bug fixes #246

Merged
merged 11 commits into from
Nov 28, 2024
Prev Previous commit
Next Next commit
fix: add handleSessionChange onMount
  • Loading branch information
fmaclen committed Nov 28, 2024
commit d5f411e7bb60e4d49657df5d41e4fc978166111f
1 change: 0 additions & 1 deletion src/lib/components/ButtonDelete.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script lang="ts">
import { Check, Trash2, X } from 'lucide-svelte';
import type { Writable } from 'svelte/store';

import LL from '$i18n/i18n-svelte';
import { goto } from '$app/navigation';
Expand Down
2 changes: 0 additions & 2 deletions src/lib/components/SectionListItem.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<script lang="ts">
import { writable } from 'svelte/store';

import LL from '$i18n/i18n-svelte';
import { page } from '$app/stores';
import { Sitemap } from '$lib/sitemap';
Expand Down
6 changes: 1 addition & 5 deletions src/routes/knowledge/[id]/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@

<svelte:fragment slot="nav">
{#if !isNewKnowledge}
<ButtonDelete
sitemap={Sitemap.KNOWLEDGE}
id={knowledge.id}
bind:shouldConfirmDeletion
/>
<ButtonDelete sitemap={Sitemap.KNOWLEDGE} id={knowledge.id} bind:shouldConfirmDeletion />
{/if}
</svelte:fragment>
</Header>
Expand Down
8 changes: 5 additions & 3 deletions src/routes/sessions/[id]/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@
isNewSession: true
});
let messagesWindow: HTMLDivElement | undefined = $state();
let userScrolledUp = $state(false);
let modelName: string | undefined = $state();
let userScrolledUp = $state(false);
let shouldConfirmDeletion = $state(false);

$effect(() => {
session.model = $settingsStore.models.find((m) => m.name === modelName)
session.model = $settingsStore.models.find((m) => m.name === modelName);
});

$effect(() => {
Expand All @@ -67,6 +67,7 @@
});

onMount(async () => {
handleSessionChange();
await scrollToBottom();
messagesWindow?.addEventListener('scroll', handleScroll);
});
Expand All @@ -82,10 +83,11 @@
});

async function handleSessionChange() {
console.log('handleSessionChange');
session = loadSession(data.id);
modelName = session.model?.name || '';
editor.view = 'messages';
editor.isNewSession = !session?.messages.length;
editor.isNewSession = !session?.messages?.length;
scrollToBottom();
}

Expand Down
2 changes: 0 additions & 2 deletions src/routes/sessions/[id]/Controls.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<script lang="ts">
import type { Writable } from 'svelte/store';

import LL from '$i18n/i18n-svelte';
import FieldCheckbox from '$lib/components/FieldCheckbox.svelte';
import FieldInput from '$lib/components/FieldInput.svelte';
Expand Down
2 changes: 0 additions & 2 deletions src/routes/sessions/[id]/Messages.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<script lang="ts">
import type { Writable } from 'svelte/store';

import LL from '$i18n/i18n-svelte';
import EmptyMessage from '$lib/components/EmptyMessage.svelte';
import { saveSession, type Editor, type Message, type Session } from '$lib/sessions';
Expand Down
Loading